From: Christoph Hellwig <hch@lst.de>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: odd change to drivers/net/ibm_newemac/core.c
Date: Thu, 23 Oct 2008 23:41:48 +0200 [thread overview]
Message-ID: <20081023214148.GA32322@lst.de> (raw)
+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
+#else
+ printk(KERN_ERR "%s: Flow control not disabled!\n",
+ np->full_name);
+ return -ENXIO;
+#endif
What's this trying to do? CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't
exist anywhere, and it seems like an extremly strange idea for a config
option. And "Flow control not disabled" is not an extremly useful error
message for users either..
next reply other threads:[~2008-10-23 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 21:41 Christoph Hellwig [this message]
2008-10-23 21:46 ` odd change to drivers/net/ibm_newemac/core.c Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023214148.GA32322@lst.de \
--to=hch@lst.de \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).