* odd change to drivers/net/ibm_newemac/core.c
@ 2008-10-23 21:41 Christoph Hellwig
2008-10-23 21:46 ` Josh Boyer
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2008-10-23 21:41 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev
+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
+#else
+ printk(KERN_ERR "%s: Flow control not disabled!\n",
+ np->full_name);
+ return -ENXIO;
+#endif
What's this trying to do? CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't
exist anywhere, and it seems like an extremly strange idea for a config
option. And "Flow control not disabled" is not an extremly useful error
message for users either..
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: odd change to drivers/net/ibm_newemac/core.c
2008-10-23 21:41 odd change to drivers/net/ibm_newemac/core.c Christoph Hellwig
@ 2008-10-23 21:46 ` Josh Boyer
0 siblings, 0 replies; 2+ messages in thread
From: Josh Boyer @ 2008-10-23 21:46 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linuxppc-dev
On Thu, 23 Oct 2008 23:41:48 +0200
Christoph Hellwig <hch@lst.de> wrote:
> +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
> dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
> +#else
> + printk(KERN_ERR "%s: Flow control not disabled!\n",
> + np->full_name);
> + return -ENXIO;
> +#endif
>
> What's this trying to do? CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't
> exist anywhere, and it seems like an extremly strange idea for a config
Damnit. Typo. Should be CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL. It's right
elsewhere, I just fat-fingered the option with this particular change
because I was rushing for a build fix. I'll fix it with the brown
paper bag of shame over my head shortly.
> option. And "Flow control not disabled" is not an extremly useful error
> message for users either..
Normal users aren't supposed to set it. The option is selected by the
4xx platform config options on boards that need the feature. This is
how other things are done in the EMAC driver.
josh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-23 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23 21:41 odd change to drivers/net/ibm_newemac/core.c Christoph Hellwig
2008-10-23 21:46 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).