From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: jhsiao@amcc.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] AMCC Crypto4xx Device Driver v2]
Date: Wed, 29 Oct 2008 13:10:32 -0400 [thread overview]
Message-ID: <20081029131032.07a3be35@zod.rchland.ibm.com> (raw)
In-Reply-To: <1225299899.4841.7.camel@jhsiao-usb>
On Wed, 29 Oct 2008 10:04:59 -0700
James Hsiao <jhsiao@amcc.com> wrote:
> > > > - Complete lack of locking code, how do you enforce mutually exclusive
> > > > access to the device?
> > >
> > > The crypto engine have couple bits 'command ready' and 'packet done',
> > > which servers as semaphore here. So, software don't need extra locking.
> >
> > know if it's applicable at all, but I imagine it's not SMP safe.
>
> No, it's not SMP safe. This driver only support single core processors.
What about preemption? You do not have to be a multi-core CPU to have
SMP-like problems.
josh
next prev parent reply other threads:[~2008-10-29 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 23:41 [PATCH] AMCC Crypto4xx Device Driver v2] James Hsiao
2008-10-29 0:51 ` Josh Boyer
2008-10-29 2:18 ` James Hsiao
2008-10-29 15:54 ` Kim Phillips
2008-10-29 17:04 ` James Hsiao
2008-10-29 17:10 ` Josh Boyer [this message]
2008-10-29 19:03 ` James Hsiao
2008-10-29 13:54 ` Josh Boyer
2008-10-29 23:54 ` James Hsiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029131032.07a3be35@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=jhsiao@amcc.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).