linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Connecting to "PCI command write" interrupt on 4xx platforms
Date: Mon, 3 Nov 2008 14:45:00 +0100	[thread overview]
Message-ID: <200811031445.00963.matthias.fuchs@esd-electronics.com> (raw)
In-Reply-To: <1225709863.8004.252.camel@pasglop>

On Monday 03 November 2008 11:57, Benjamin Herrenschmidt wrote:
> On Mon, 2008-11-03 at 10:10 +0100, Matthias Fuchs wrote:
> > 
> > Adding this interrupt to the PCI node would make (logical) sense. But
> > on PCI adapter (add-in cards) designs we typically disable the PCI node
> > of the DT to disable PCI PnP. This should not prevent us from adding the
> > interrupt to the node but it looks a little bit weird to take an interrupt
> > from a disabled node, right?
> 
> You can make a pci-endpoint node that isn't detected as a host bridge.
> In fact, I think we have some way to even tell in the DT not to activate
> host bridge function on 44x nowadays no ? I dont remember for sure but
> it's easy enough to add.
We have endpoint support for PCIe and the possibility to disable PCI through the status
attribute.
> 
> > > the actual PCI bridge, then you can stick an interrupts property in the
> > > PCI host bridge node in the DT just fine.
> > The PCI node already contains the interrupt-map for the PCI interrupts.
> 
> Only relevant for master, not endpoint.
> 
> > Doesn't adding a further interrupt property cause some trouble with the PCI interrupts?
> 
> Not for endpoint.
I see.

I will try to add endpoint support for PCI as well. I would like to have a single PCI node and
let the device_type attribute decide if we are running in hostbridge or endpoint mode.

Matthias

  parent reply	other threads:[~2008-11-03 13:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 10:58 Connecting to "PCI command write" interrupt on 4xx platforms Matthias Fuchs
2008-10-30 20:15 ` Benjamin Herrenschmidt
2008-11-03  9:10   ` Matthias Fuchs
2008-11-03 10:57     ` Benjamin Herrenschmidt
2008-11-03 11:54       ` Stefan Roese
2008-11-03 13:40         ` Matthias Fuchs
2008-11-03 13:45       ` Matthias Fuchs [this message]
2008-11-03 20:19         ` Benjamin Herrenschmidt
2008-11-04  5:19           ` Stefan Roese
2008-11-04  6:16             ` Benjamin Herrenschmidt
2008-11-04 11:17               ` Matthias Fuchs
2008-11-04 21:29                 ` Benjamin Herrenschmidt
2008-11-05 20:32                   ` Matthias Fuchs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811031445.00963.matthias.fuchs@esd-electronics.com \
    --to=matthias.fuchs@esd-electronics.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).