From: Sonny Rao <sonnyrao@us.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: paulus@samba.org
Subject: [PATCH] Fix BSR to allow mmap of small BSR on 64k kernel
Date: Thu, 6 Nov 2008 18:38:41 -0600 [thread overview]
Message-ID: <20081107003841.GE7533@us.ibm.com> (raw)
Fix the BSR driver to allow small BSR devices, which are limited to a
single 4k space, on a 64k page kernel. Previously the driver would
reject the mmap since the size was smaller than PAGESIZE (or because
the size was greater than the size of the device). Now, we check for
this case use remap_4k_pfn(). Also, take out code to set vm_flags,
as the remap_pfn functions will do this for us.
Signed-off-by: Sonny Rao <sonnyrao@us.ibm.com>
Index: common/drivers/char/bsr.c
===================================================================
--- common.orig/drivers/char/bsr.c 2008-11-06 16:43:58.000000000 -0600
+++ common/drivers/char/bsr.c 2008-11-06 18:30:41.000000000 -0600
@@ -27,6 +27,7 @@
#include <linux/cdev.h>
#include <linux/list.h>
#include <linux/mm.h>
+#include <asm/pgtable.h>
#include <asm/io.h>
/*
@@ -115,15 +116,23 @@
{
unsigned long size = vma->vm_end - vma->vm_start;
struct bsr_dev *dev = filp->private_data;
+ int ret;
- if (size > dev->bsr_len || (size & (PAGE_SIZE-1)))
- return -EINVAL;
+ /* This is legal where we have a BSR on a 4k page but a 64k kernel */
+ if (size > dev->bsr_len)
+ size = dev->bsr_len;
- vma->vm_flags |= (VM_IO | VM_DONTEXPAND);
vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
- if (io_remap_pfn_range(vma, vma->vm_start, dev->bsr_addr >> PAGE_SHIFT,
- size, vma->vm_page_prot))
+ if (dev->bsr_len < PAGE_SIZE)
+ ret = remap_4k_pfn(vma, vma->vm_start, dev->bsr_addr >> 12,
+ vma->vm_page_prot);
+ else
+ ret = io_remap_pfn_range(vma, vma->vm_start,
+ dev->bsr_addr >> PAGE_SHIFT,
+ size, vma->vm_page_prot);
+
+ if (ret)
return -EAGAIN;
return 0;
next reply other threads:[~2008-11-07 0:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 0:38 Sonny Rao [this message]
2008-11-07 5:28 ` [PATCH] Fix BSR to allow mmap of small BSR on 64k kernel Paul Mackerras
2008-11-07 23:25 ` Sonny Rao
2008-11-17 7:26 ` Sonny Rao
2008-11-19 4:07 ` Paul Mackerras
2008-11-19 17:04 ` Sonny Rao
2008-11-19 22:54 ` Paul Mackerras
2008-11-20 19:20 ` Sonny Rao
2009-06-19 1:13 ` Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107003841.GE7533@us.ibm.com \
--to=sonnyrao@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).