From: David Gibson <dwg@au1.ibm.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org,
yanok@emcraft.com, Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH] [v2] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way
Date: Wed, 12 Nov 2008 10:20:06 +1100 [thread overview]
Message-ID: <20081111232006.GA17193@yookeroo.seuss> (raw)
In-Reply-To: <20081111125218.GA2266@yoda.jdub.homelinux.org>
On Tue, Nov 11, 2008 at 07:52:18AM -0500, Josh Boyer wrote:
> On Mon, Nov 10, 2008 at 05:24:34PM -0600, Hollis Blanchard wrote:
> >The current CHIP11 errata truncates the device tree memory node, and subtracts
> >(hardcoded) 4096 bytes. This breaks kernels with larger PAGE_SIZE, since the
> >bootmem allocator assumes that total memory is a multiple of PAGE_SIZE.
> >
> >Instead, use a device tree memory reservation to reserve only the 256 bytes
> >actually affected by the errata, leaving the total memory size unaltered.
> >
> >Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> >
> >---
> >
> >Using large pages results in a huge performance improvement for KVM, and this
> >patch is required to make Ilya's large page patch work. David and/or Josh,
> >please apply.
>
> The patch looks fine to me, and once David acks the fdt parts I'll apply
> for -next. I'll try to do some testing later today as well, since I have
> one of the boards with the Errata.
Um.. I sent something the fdt stuff a while back, but didn't get a
response.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2008-11-11 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 23:24 [PATCH] [v2] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way Hollis Blanchard
2008-11-11 12:52 ` Josh Boyer
2008-11-11 23:20 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111232006.GA17193@yookeroo.seuss \
--to=dwg@au1.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).