From: Wolfram Sang <w.sang@pengutronix.de>
To: "Lehmann, Hans (Ritter Elektronik)" <hans.lehmann@ritter-elektronik.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v1] RS485 support for MPC5200x_psc_uart
Date: Thu, 13 Nov 2008 19:42:18 +0100 [thread overview]
Message-ID: <20081113184218.GA11602@pengutronix.de> (raw)
In-Reply-To: <633A55242A59C7488FAAF5A6850929984B813E@SRVEXC01.sts.saurer.vpn>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
Hello Hans,
On Thu, Nov 13, 2008 at 04:48:30PM +0100, Lehmann, Hans (Ritter Elektronik) wrote:
> Adds rs485 support for MPC52xx_psc_uart
Please be more specific. What exactly was done/modified to have
RS485-support.
Please also read SubmittingPatches and CodingStyle in the Documentation
directory and adapt your patch accordingly. For example: Send patches
inlined, this makes reviewing a lot easier. Don't use magic numbers. Use
spaces around operators. All this helps maintaining your code in the
future.
> COM1 is console and not selectable.
COM1 is rarely selectable in Linux ;)
Kind regards,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-13 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 15:48 [PATCH v1] RS485 support for MPC5200x_psc_uart Lehmann, Hans (Ritter Elektronik)
2008-11-13 18:42 ` Wolfram Sang [this message]
2008-11-17 15:27 ` AW: " Lehmann, Hans (Ritter Elektronik)
2008-11-27 22:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113184218.GA11602@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=hans.lehmann@ritter-elektronik.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).