From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Yuri Tikhonov <yur@emcraft.com>
Cc: Ilya Yanok <yanok@emcraft.com>, Detlev Zundel <dzu@denx.de>,
Wolfgang, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Denk <wd@denx.de>
Subject: Re: [PATCH] xsysace: use resource_size_t instead of unsigned long
Date: Thu, 13 Nov 2008 21:21:21 +1100 [thread overview]
Message-ID: <20081113212121.e7a9f5fe.sfr@canb.auug.org.au> (raw)
In-Reply-To: <200811131143.17752.yur@emcraft.com>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Hi Yuri,
On Thu, 13 Nov 2008 11:43:17 +0300 Yuri Tikhonov <yur@emcraft.com> wrote:
>
> - dev_dbg(ace->dev, "physaddr=0x%lx irq=%i\n", ace->physaddr, ace->irq);
> + dev_dbg(ace->dev, "physaddr=0x%llx irq=%i\n", (u64)ace->physaddr, ace->irq);
You should cast the physaddr to "unsigned long long" as "u64" is
"unsigned long" on some architectures. The same is needed in other
places as well.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-13 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 8:43 [PATCH] xsysace: use resource_size_t instead of unsigned long Yuri Tikhonov
2008-11-13 10:21 ` Stephen Rothwell [this message]
2008-11-14 4:57 ` Re[2]: " Yuri Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113212121.e7a9f5fe.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dzu@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).