* [patch 0/1] hvc_console: fix: remove duplicate hp->ws winsize check
@ 2008-11-18 11:28 Hendrik Brueckner
2008-11-18 11:28 ` [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync Hendrik Brueckner
0 siblings, 1 reply; 4+ messages in thread
From: Hendrik Brueckner @ 2008-11-18 11:28 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Linux PPC devel, Jeremy Fitzhardinge,
Rusty Russell, Ryan S. Arnold
Cc: Martin Schwidefsky, Christian Borntraeger, Heiko Carstens, LKML
Hello,
this patch fixes a hvc terminal resize problem by removing a duplicate
winsize comparison.
Ben, could you add this patch to your tree for 2.6.28-rc6 bug fixes?
Thanks and regards,
Hendrik
--
Hendrik Brueckner
D/3303 Linux on System z Development
eMail: brueckner@linux.vnet.ibm.com
IBM Deutschland Research & Development GmbH, Schoenaicher Str. 220, 71032 Boeblingen
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Erich Baier
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync
2008-11-18 11:28 [patch 0/1] hvc_console: fix: remove duplicate hp->ws winsize check Hendrik Brueckner
@ 2008-11-18 11:28 ` Hendrik Brueckner
2008-12-03 9:17 ` Paul Mackerras
0 siblings, 1 reply; 4+ messages in thread
From: Hendrik Brueckner @ 2008-11-18 11:28 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Linux PPC devel, Jeremy Fitzhardinge,
Rusty Russell, Ryan S. Arnold
Cc: Martin Schwidefsky, Christian Borntraeger, Hendrik Brueckner,
Heiko Carstens, LKML
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
The test to check for a new winsize runs out-of-sync with the underlying
tty. After a tty has been released and initialized again, the winsize might
differ between the tty and the hp struct.
The solution is to simply remove the check and always schedule the resize work.
Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
drivers/char/hvc_console.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -689,10 +689,8 @@ EXPORT_SYMBOL_GPL(hvc_poll);
*/
void hvc_resize(struct hvc_struct *hp, struct winsize ws)
{
- if ((hp->ws.ws_row != ws.ws_row) || (hp->ws.ws_col != ws.ws_col)) {
- hp->ws = ws;
- schedule_work(&hp->tty_resize);
- }
+ hp->ws = ws;
+ schedule_work(&hp->tty_resize);
}
/*
--
Hendrik Brueckner
D/3303 Linux on System z Development
Tel: +49 7031 16-1073
Fax: +49 7031 16-3456
eMail: brueckner@linux.vnet.ibm.com
IBM Deutschland Research & Development GmbH, Schoenaicher Str. 220, 71032 Boeblingen
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Erich Baier
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync
2008-11-18 11:28 ` [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync Hendrik Brueckner
@ 2008-12-03 9:17 ` Paul Mackerras
2008-12-03 9:28 ` Hendrik Brueckner
0 siblings, 1 reply; 4+ messages in thread
From: Paul Mackerras @ 2008-12-03 9:17 UTC (permalink / raw)
To: Hendrik Brueckner
Cc: Jeremy Fitzhardinge, Christian Borntraeger, Rusty Russell,
Heiko Carstens, LKML, Linux PPC devel, Martin Schwidefsky
Hendrik Brueckner writes:
> From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
>
> The test to check for a new winsize runs out-of-sync with the underlying
> tty. After a tty has been released and initialized again, the winsize might
> differ between the tty and the hp struct.
> The solution is to simply remove the check and always schedule the resize work.
Looks OK. Is this going to go in via the s390 tree, or should I put
it in the powerpc tree?
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync
2008-12-03 9:17 ` Paul Mackerras
@ 2008-12-03 9:28 ` Hendrik Brueckner
0 siblings, 0 replies; 4+ messages in thread
From: Hendrik Brueckner @ 2008-12-03 9:28 UTC (permalink / raw)
To: Paul Mackerras
Cc: Jeremy Fitzhardinge, Christian Borntraeger, Rusty Russell,
Heiko Carstens, LKML, Linux PPC devel, Hendrik Brueckner,
Martin Schwidefsky
Hi Paul,
On Wed, Dec 03, 2008 at 08:17:13PM +1100, Paul Mackerras wrote:
> Looks OK. Is this going to go in via the s390 tree, or should I put
> it in the powerpc tree?
The patch should go via the powerpc tree.
Thanks and regards,
Hendrik
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-12-03 9:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-18 11:28 [patch 0/1] hvc_console: fix: remove duplicate hp->ws winsize check Hendrik Brueckner
2008-11-18 11:28 ` [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync Hendrik Brueckner
2008-12-03 9:17 ` Paul Mackerras
2008-12-03 9:28 ` Hendrik Brueckner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).