Re: [PATCH] cpm2: Round the baud-rate clock divider to the nearest integer.

[Laurent Pinchart <laurentp@cse-semaphore.com>]

Hi Kumar,

On Thursday 20 November 2008 16:32:21 Kumar Gala wrote:
> On Nov 20, 2008, at 6:32 AM, Laurent Pinchart wrote:
> > Instead of rounding the divider down, improve the baud-rate generators
> > accuracy by rounding to the nearest integer.
> >
> > Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> > ---
> > arch/powerpc/sysdev/cpm2.c |    3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
>
> is this fixing a bug or just making things better?

I guess it depends on your definition of bug :-) The problem has always been 
present in the kernel sources, and people seem to have coped with it until 
today. It is still a bug in my opinion, but I suppose the patch can wait until 
2.6.29 especially if we want to get it tested (it slightly changes baud rates 
after all).

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75