From: Benjamin Krill <ben@codiert.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linuxppc-dev@ozlabs.org, linux-serial@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] Add support for the nwp serial device
Date: Sun, 23 Nov 2008 22:46:11 +0100 [thread overview]
Message-ID: <20081123214611.GS24487@codiert.org> (raw)
In-Reply-To: <20081121132244.e9e9fd74.akpm@linux-foundation.org>
* Andrew Morton | 2008-11-21 13:22:44 [-0800]:
>(does a powerpc allmodconfig)
>
>drivers/serial/nwpserial.c:443: warning: data definition has no type or storage class
>drivers/serial/nwpserial.c:443: warning: type defaults to 'int' in declaration of 'console_initcall'
>drivers/serial/nwpserial.c:443: warning: parameter names (without types) in function declaration
>drivers/serial/nwpserial.c:400: warning: 'nwpserial_console_init' defined but not used
>
>The file fails to include linux/init.h. It should do so, but that
>doesn't fix the above.
>
>Apparently it hasn't been tested as a kernel module...
Console support doesn't work when the driver is build as module, all
other serial drivers did this with a further configuration option. Will
send an updated patch which fixes this and the other issues.
next prev parent reply other threads:[~2008-11-23 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 14:01 [PATCH] Add support for the nwp serial device Arnd Bergmann
2008-11-20 14:13 ` Josh Boyer
2008-11-20 15:20 ` Benjamin Krill
2008-11-20 15:40 ` Josh Boyer
2008-11-21 0:35 ` David Gibson
2008-11-21 7:21 ` Benjamin Krill
2008-11-21 7:29 ` David Gibson
2008-11-21 21:22 ` Andrew Morton
2008-11-23 21:46 ` Benjamin Krill [this message]
2008-11-22 22:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123214611.GS24487@codiert.org \
--to=ben@codiert.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).