From: Arnd Bergmann <arnd@arndb.de>
To: Carl Love <cel@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org, cel <cel@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
oprofile-list@lists.sourceforge.net,
cbe-oss-dev <cbe-oss-dev@ozlabs.org>
Subject: Re: [Patch 2/3] OProfile SPU event profiling support for IBM Cell processor
Date: Tue, 25 Nov 2008 16:58:26 +0100 [thread overview]
Message-ID: <200811251658.27387.arnd@arndb.de> (raw)
In-Reply-To: <1227569201.6509.214.camel@carll-linux-desktop>
On Tuesday 25 November 2008, Carl Love wrote:
>
> This patch basically rearranges the code a bit to make it easier to
> just add the needed SPU event based profiling routines. The second
> kernel patch contains the new spu event based profiling code.
The cleanup looks fine, but should get a unique patch name, e.g.
'[PATCH 2/3] powerpc/cell/oprofile: clean up event handling' to
make the shortlog more meaningful. No need to mention in the changelog
what the other patch does.
Please mention that this patch is not supposed to change any behaviour.
> Signed-off-by: Carl Love <carll@us.ibm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2008-11-25 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 23:26 [Patch 2/3] OProfile SPU event profiling support for IBM Cell processor Carl Love
2008-11-25 15:58 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811251658.27387.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cel@linux.vnet.ibm.com \
--cc=cel@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=oprofile-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox