* [PATCH] powerpc/83xx: Fix MCU support merge issue in mpc8349emitx.dts
@ 2008-11-27 17:36 Anton Vorontsov
2008-12-03 15:57 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Anton Vorontsov @ 2008-11-27 17:36 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
Just found the merge issue in 442746989d92afc125040e0f29b33602ad94da99
("powerpc/83xx: Add support for MCU microcontroller in .dts files"):
the commit adds the MCU controller node into the DMA node, which is
wrong because the MCU sits on the I2C bus. Fix this by moving the MCU
node into the I2C controller node.
The original patch[1] was OK though. ;-)
[1] http://patchwork.ozlabs.org/patch/4895/
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8349emitx.dts | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 2c9d54a..4bdbaf4 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -91,6 +91,14 @@
interrupts = <18 0x8>;
interrupt-parent = <&ipic>;
};
+
+ mcu_pio: mcu@a {
+ #gpio-cells = <2>;
+ compatible = "fsl,mc9s08qg8-mpc8349emitx",
+ "fsl,mcu-mpc8349emitx";
+ reg = <0x0a>;
+ gpio-controller;
+ };
};
spi@7000 {
@@ -139,14 +147,6 @@
interrupt-parent = <&ipic>;
interrupts = <71 8>;
};
-
- mcu_pio: mcu@a {
- #gpio-cells = <2>;
- compatible = "fsl,mc9s08qg8-mpc8349emitx",
- "fsl,mcu-mpc8349emitx";
- reg = <0x0a>;
- gpio-controller;
- };
};
usb@22000 {
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/83xx: Fix MCU support merge issue in mpc8349emitx.dts
2008-11-27 17:36 [PATCH] powerpc/83xx: Fix MCU support merge issue in mpc8349emitx.dts Anton Vorontsov
@ 2008-12-03 15:57 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2008-12-03 15:57 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Nov 27, 2008, at 11:36 AM, Anton Vorontsov wrote:
> Just found the merge issue in 442746989d92afc125040e0f29b33602ad94da99
> ("powerpc/83xx: Add support for MCU microcontroller in .dts files"):
> the commit adds the MCU controller node into the DMA node, which is
> wrong because the MCU sits on the I2C bus. Fix this by moving the MCU
> node into the I2C controller node.
>
> The original patch[1] was OK though. ;-)
>
> [1] http://patchwork.ozlabs.org/patch/4895/
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8349emitx.dts | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
applied to merge
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-03 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-27 17:36 [PATCH] powerpc/83xx: Fix MCU support merge issue in mpc8349emitx.dts Anton Vorontsov
2008-12-03 15:57 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).