From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Mackerras <paulus@samba.org>
Cc: roel kluin <roel.kluin@gmail.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative
Date: Sun, 30 Nov 2008 11:16:14 +0000 [thread overview]
Message-ID: <20081130111614.21b194c5@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <18737.52782.650416.444270@cargo.ozlabs.ibm.com>
> Also, I don't see why those changes have anything to do with "unsigned
> things cannot be negative". As long as those counts are never zero on
> entry to those code sections, the existing code is fine, and I believe
> that assertion can be maintained. If you believe the code needs to
> defend against the possibility of a zero count on entry, that should
> have been explicitly stated in the patch description.
See the tty_port patches in -next - this is an argument about code which
ought eventually to go away replaced by standard helper functions.
next prev parent reply other threads:[~2008-11-30 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 10:57 powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative roel kluin
2008-11-29 12:54 ` Andreas Schwab
2008-11-29 13:27 ` roel kluin
2008-11-29 15:01 ` Andreas Schwab
2008-11-29 23:20 ` Paul Mackerras
2008-11-30 11:16 ` Alan Cox [this message]
2008-11-30 21:23 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081130111614.21b194c5@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).