From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Hollis Blanchard <hollis@penguinppc.org>
Cc: wd@denx.de, Ilya Yanok <yanok@emcraft.com>,
linuxppc-dev@ozlabs.org, Vladimir Panfilov <pvr@emcraft.com>,
dzu@denx.de
Subject: Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
Date: Mon, 1 Dec 2008 18:22:48 -0500 [thread overview]
Message-ID: <20081201232248.GB15923@zod.rchland.ibm.com> (raw)
In-Reply-To: <fb412d760812011506x37339fddue100a144e585782e@mail.gmail.com>
On Mon, Dec 01, 2008 at 05:06:03PM -0600, Hollis Blanchard wrote:
>On Thu, Nov 27, 2008 at 5:44 PM, Ilya Yanok <yanok@emcraft.com> wrote:
>> This patch adds support for page sizes bigger than 4K (16K/64K) on
>> PPC 44x.
>> PGDIR table is much smaller than page in case of 16K/64K pages (512
>> and 32 bytes resp.) so we allocate PGDIR with kzalloc() instead of
>> __get_free_pages().
>> PTE table covers rather big memory area in case of 16K/64K pages
>> (32MB and 512MB resp.) so we can easily put FIXMAP and PKMAP in
>> area covered by one PTE table.
>
>Ben, you had some comments on the previous version of this patch. Have
>those been addressed to your satisfaction? If so, could you please
>queue this for 2.6.29?
Milton had some comments too. And I'd also like to review it and add
and Acked-by since I'll be the one getting bug reports if it's broken :).
I've been sick for the past few days, but this is the first thing to
review on my list tomorrow.
josh
next prev parent reply other threads:[~2008-12-01 23:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 23:44 [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures Ilya Yanok
2008-12-01 23:06 ` Hollis Blanchard
2008-12-01 23:22 ` Josh Boyer [this message]
2008-12-02 0:09 ` Benjamin Herrenschmidt
2008-12-09 21:39 ` Benjamin Herrenschmidt
2008-12-10 11:21 ` Re[2]: " Yuri Tikhonov
2008-12-10 19:58 ` Benjamin Herrenschmidt
2008-12-11 1:51 ` Ilya Yanok
2008-12-10 13:58 ` Ilya Yanok
2008-12-11 1:39 ` Ilya Yanok
2008-12-11 1:55 ` Ilya Yanok
2008-12-17 19:56 ` Josh Boyer
2008-12-24 17:03 ` Josh Boyer
2008-12-26 21:22 ` Benjamin Herrenschmidt
2008-12-27 12:05 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201232248.GB15923@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=dzu@denx.de \
--cc=hollis@penguinppc.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=pvr@emcraft.com \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).