From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
Date: Wed, 3 Dec 2008 22:33:27 +0300 [thread overview]
Message-ID: <20081203193327.GA13807@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20081108175254.GA6444@oksana.dev.rtsoft.ru>
On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote:
> Boards should know when QE_USB is used, so that they can configure USB
> clocks and pins.
>
> Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
> but selects are evil since they don't support dependencies.
>
> While at it, also remove 'host' from the symbol description, since the
> QE_USB code is used to support the gadget driver as well.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
Anything wrong with this one?
Thanks,
> arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
> index 76ffbc4..41ac3df 100644
> --- a/arch/powerpc/sysdev/qe_lib/Kconfig
> +++ b/arch/powerpc/sysdev/qe_lib/Kconfig
> @@ -22,5 +22,6 @@ config UCC
>
> config QE_USB
> bool
> + default y if USB_GADGET_FSL_QE
> help
> - QE USB Host Controller support
> + QE USB Controller support
> --
> 1.5.6.3
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-12-03 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 17:52 [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE Anton Vorontsov
2008-11-10 18:16 ` Scott Wood
2008-12-03 19:33 ` Anton Vorontsov [this message]
2008-12-23 17:22 ` Anton Vorontsov
2008-12-30 18:12 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203193327.GA13807@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).