linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards
@ 2008-10-17 18:57 Anton Vorontsov
  2008-10-21  4:39 ` Kumar Gala
  2008-12-03 23:10 ` Timur Tabi
  0 siblings, 2 replies; 4+ messages in thread
From: Anton Vorontsov @ 2008-10-17 18:57 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev

MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
provide soft power-off function, but also exports two GPIOs (wired to
the LEDs and also available from the external headers).

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 arch/powerpc/boot/dts/mpc8315erdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8349emitx.dts |    8 ++++++++
 arch/powerpc/boot/dts/mpc8377_rdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8378_rdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8379_rdb.dts  |    8 ++++++++
 5 files changed, 40 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/boot/dts/mpc8315erdb.dts
index 7449e54..6b85067 100644
--- a/arch/powerpc/boot/dts/mpc8315erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8315erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		spi@7000 {
diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 7fc5414..4bdbaf4 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -91,6 +91,14 @@
 				interrupts = <18 0x8>;
 				interrupt-parent = <&ipic>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8349emitx",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		spi@7000 {
diff --git a/arch/powerpc/boot/dts/mpc8377_rdb.dts b/arch/powerpc/boot/dts/mpc8377_rdb.dts
index 53191ba..435ef3d 100644
--- a/arch/powerpc/boot/dts/mpc8377_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc8377_rdb.dts
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8377erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
diff --git a/arch/powerpc/boot/dts/mpc8378_rdb.dts b/arch/powerpc/boot/dts/mpc8378_rdb.dts
index 4a09153..b11e68f 100644
--- a/arch/powerpc/boot/dts/mpc8378_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc8378_rdb.dts
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8378erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
diff --git a/arch/powerpc/boot/dts/mpc8379_rdb.dts b/arch/powerpc/boot/dts/mpc8379_rdb.dts
index bbd884a..337af6e 100644
--- a/arch/powerpc/boot/dts/mpc8379_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc8379_rdb.dts
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8379erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards
  2008-10-17 18:57 [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards Anton Vorontsov
@ 2008-10-21  4:39 ` Kumar Gala
  2008-12-03 23:10 ` Timur Tabi
  1 sibling, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2008-10-21  4:39 UTC (permalink / raw)
  To: Anton Vorontsov; +Cc: linuxppc-dev


On Oct 17, 2008, at 1:57 PM, Anton Vorontsov wrote:

> MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> provide soft power-off function, but also exports two GPIOs (wired to
> the LEDs and also available from the external headers).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8315erdb.dts  |    8 ++++++++
> arch/powerpc/boot/dts/mpc8349emitx.dts |    8 ++++++++
> arch/powerpc/boot/dts/mpc8377_rdb.dts  |    8 ++++++++
> arch/powerpc/boot/dts/mpc8378_rdb.dts  |    8 ++++++++
> arch/powerpc/boot/dts/mpc8379_rdb.dts  |    8 ++++++++
> 5 files changed, 40 insertions(+), 0 deletions(-)

applied

- k

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards
  2008-10-17 18:57 [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards Anton Vorontsov
  2008-10-21  4:39 ` Kumar Gala
@ 2008-12-03 23:10 ` Timur Tabi
  2008-12-03 23:44   ` Anton Vorontsov
  1 sibling, 1 reply; 4+ messages in thread
From: Timur Tabi @ 2008-12-03 23:10 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev

On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> provide soft power-off function, but also exports two GPIOs (wired to
> the LEDs and also available from the external headers).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Kumar, I think you merged this patch incorrectly ...

> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> index 7fc5414..4bdbaf4 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> @@ -91,6 +91,14 @@
>                                interrupts = <18 0x8>;
>                                interrupt-parent = <&ipic>;
>                        };
> +
> +                       mcu_pio: mcu@a {
> +                               #gpio-cells = <2>;
> +                               compatible = "fsl,mc9s08qg8-mpc8349emitx",
> +                                            "fsl,mcu-mpc8349emitx";
> +                               reg = <0x0a>;
> +                               gpio-controller;
> +                       };

This node is supposed to go under the I2C node, but you put it under
the DMA node.

-- 
Timur Tabi
Linux kernel developer at Freescale

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards
  2008-12-03 23:10 ` Timur Tabi
@ 2008-12-03 23:44   ` Anton Vorontsov
  0 siblings, 0 replies; 4+ messages in thread
From: Anton Vorontsov @ 2008-12-03 23:44 UTC (permalink / raw)
  To: Timur Tabi; +Cc: linuxppc-dev

On Wed, Dec 03, 2008 at 05:10:30PM -0600, Timur Tabi wrote:
> On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> > provide soft power-off function, but also exports two GPIOs (wired to
> > the LEDs and also available from the external headers).
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> Kumar, I think you merged this patch incorrectly ...
[...]
> This node is supposed to go under the I2C node, but you put it under
> the DMA node.

I've noticed this on the other 'stg pull', when it told me that the
patch isn't empty (stg patch becomes empty if merged).

This should be fixed already:

http://ozlabs.org/pipermail/linuxppc-dev/2008-November/065666.html

Anyway, thanks for heads up!

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-12-03 23:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-17 18:57 [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards Anton Vorontsov
2008-10-21  4:39 ` Kumar Gala
2008-12-03 23:10 ` Timur Tabi
2008-12-03 23:44   ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).