From: Arnd Bergmann <arnd@arndb.de>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: linuxppc-dev@ozlabs.org, Mijo Safradin <safradin@de.ibm.com>,
Cliff Wickman <cpw@sgi.com>, Christoph Lameter <clameter@sgi.com>
Subject: [PATCH, v2] numactl: fix libnuma on big-endian 64-bit systems
Date: Thu, 4 Dec 2008 21:51:58 +0100 [thread overview]
Message-ID: <200812042151.58676.arnd@arndb.de> (raw)
In-Reply-To: <200812042149.06163.arnd@arndb.de>
The read-mask function assumes that it is running in 32-bit mode,
by addressing the bitmask as a series of int values, instead of
longs. This is broken as can easily be reproduced by running numademo
on a bit-endian 64-bit system.
Changing the addressing to use 'long' values fixes the problem.
Reported-by: Mijo Safradin <safradin@de.ibm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
libnuma.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libnuma.c b/libnuma.c
index 4d26093..9a9fbbe 100755
--- a/libnuma.c
+++ b/libnuma.c
@@ -376,9 +376,9 @@ read_mask(char *s, struct bitmask *bmp)
{
char *end = s;
char *prevend;
- unsigned int *start = (unsigned int *)bmp->maskp;
- unsigned int *p = start;
- unsigned int *q;
+ unsigned long *start = bmp->maskp;
+ unsigned long *p = start;
+ unsigned long *q;
unsigned int i;
unsigned int n = 0;
@@ -415,14 +415,14 @@ read_mask(char *s, struct bitmask *bmp)
}
/* Poor mans fls() */
- for(i = 31; i >= 0; i--)
+ for(i = sizeof(long) * 8 - 1; i >= 0; i--)
if (test_bit(i, start + n))
break;
/*
* Return the last bit set
*/
- return ((sizeof(unsigned int)*8) * n) + i;
+ return ((sizeof(unsigned long)*8) * n) + i;
}
/*
next prev parent reply other threads:[~2008-12-04 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 17:34 [PATCH] numactl: fix libnuma on big-endian 64-bit systems Arnd Bergmann
2008-12-04 17:46 ` Lee Schermerhorn
2008-12-04 20:49 ` Arnd Bergmann
2008-12-04 20:51 ` Arnd Bergmann [this message]
2008-12-05 15:12 ` [PATCH, v2] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812042151.58676.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Lee.Schermerhorn@hp.com \
--cc=clameter@sgi.com \
--cc=cpw@sgi.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=safradin@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).