From: Kim Phillips <kim.phillips@freescale.com>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, jhsiao@amcc.com,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] AMCC Crypto4xx Device Driver v4]
Date: Mon, 8 Dec 2008 12:12:39 -0600 [thread overview]
Message-ID: <20081208121239.756f3e38.kim.phillips@freescale.com> (raw)
In-Reply-To: <200812050641.13753.sr@denx.de>
On Fri, 5 Dec 2008 06:41:13 +0100
Stefan Roese <sr@denx.de> wrote:
> On Friday 05 December 2008, Kim Phillips wrote:
> > > diff --git a/arch/powerpc/boot/dts/canyonlands.dts
> > > b/arch/powerpc/boot/dts/canyonlands.dts index 79fe412..b0f0096 100644
> > > --- a/arch/powerpc/boot/dts/canyonlands.dts
> > > +++ b/arch/powerpc/boot/dts/canyonlands.dts
> > > @@ -116,6 +116,13 @@
> > > dcr-reg = <0x010 0x002>;
> > > };
> > >
> > > + CRYPTO: crypto@180000 {
> > > + compatible = "amcc,ppc460ex-crypto", "amcc,ppc4xx-crypto";
> > > + reg = <4 0x00180000 0x80400>;
> > > + interrupt-parent = <&UIC0>;
> > > + interrupts = <0x1d 0x4>;
> >
> > that's odd, according to the current canyonlands.dts, irq 0x1d is
> > already assigned to UART2 (and the request_irq this driver makes
> > doesn't specify a shared flag).
>
> UART2 is using irq 0x1d from UIC1. Using 0x1d/UIC0 is correct for Security
> EIP-94 according to the latest users manual. No sharing needed.
ok, I didn't notice the machine had four interrupt controllers (!),
thanks.
Kim
next prev parent reply other threads:[~2008-12-08 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 22:17 [PATCH] AMCC Crypto4xx Device Driver v4] James Hsiao
2008-12-05 1:32 ` Kim Phillips
2008-12-05 5:41 ` Stefan Roese
2008-12-08 18:12 ` Kim Phillips [this message]
2008-12-05 23:24 ` James Hsiao
2008-12-08 18:09 ` Kim Phillips
2008-12-08 21:55 ` James Hsiao
2008-12-09 0:35 ` Kim Phillips
2008-12-09 0:56 ` James Hsiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208121239.756f3e38.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=jhsiao@amcc.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).