From: Stefan Roese <sr@denx.de>
To: Grant Erickson <gerickson@nuovations.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: PPC4xx ECC Configs, Defines and Source
Date: Tue, 9 Dec 2008 06:57:23 +0100 [thread overview]
Message-ID: <200812090657.23968.sr@denx.de> (raw)
In-Reply-To: <C562F078.1353A%gerickson@nuovations.com>
Hi Grant,
On Tuesday 09 December 2008, Grant Erickson wrote:
> > Just to make sure, are you planning on just implementing a driver to
> > deal with whatever settings the bootloader configured? E.g., if ECC is
> > enabled deal with correctable/uncorrectable errors and if not, do
> > nothing? Basically you are looking to implement a scrub driver, yes?
> >
> > I ask because since ECC is memory module specific and memory controller
> > setup is pretty tricky, I think it's best to leave whatever
> > configuration the bootloader set and work with that. Having to redo
> > memory controller setups in Linux to enable ECC isn't something I'd
> > look forward to.
>
> Precisely. The driver will basically check if ECC is enabled (as was
> set/not set by u-boot) and, if so, will take ECC SEC/DED interrupts, log
> SEC errors to some data structure fetchable by a proc entry or some device
> node. For DED errors, execute on some policy, at its simplest, generating a
> panic.
>
> At no point will the driver/code attempt to change the controller
> configuration beyond reading/clearing ECC event/interrupt status.
Seems that such a driver should be implemented in the Linux EDAC subsystem
(see drivers/edac and Documentation/edac.txt) to me. Did you take a look at
this?
Best regards,
Stefan
next prev parent reply other threads:[~2008-12-09 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 19:28 PPC4xx ECC Configs, Defines and Source Grant Erickson
2008-12-08 20:21 ` Josh Boyer
2008-12-08 22:08 ` Grant Erickson
2008-12-08 23:10 ` Josh Boyer
2008-12-08 23:40 ` Grant Erickson
2008-12-09 5:57 ` Stefan Roese [this message]
2008-12-09 6:32 ` Grant Erickson
2008-12-10 8:53 ` Benjamin Herrenschmidt
2008-12-10 9:07 ` Stefan Roese
2008-12-10 12:37 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812090657.23968.sr@denx.de \
--to=sr@denx.de \
--cc=gerickson@nuovations.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).