From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Trent Piepho <tpiepho@freescale.com>
Cc: linuxppc-dev@ozlabs.org, kumar.gala@freescale.com
Subject: Re: [PATCH 1/5] powerpc: booke: Don't hard-code size of struct tlbcam
Date: Tue, 9 Dec 2008 09:26:49 -0500 [thread overview]
Message-ID: <20081209092649.1d262327@zod.rchland.ibm.com> (raw)
In-Reply-To: <1228793699-23110-1-git-send-email-tpiepho@freescale.com>
On Mon, 8 Dec 2008 19:34:55 -0800
Trent Piepho <tpiepho@freescale.com> wrote:
> Some assembly code in head_fsl_booke.S hard-coded the size of struct tlbcam
> to 20 when it indexed the TLBCAM table. Anyone changing the size of struct
> tlbcam would not know to expect that.
>
> The kernel already has a system to get the size of C structures into
> assembly language files, asm-offsets, so let's use it.
>
> The definition of the struct gets moved to a header, so that asm-offsets.c
> can include it.
I don't mean to be overly picky, but your patch subjects and changelog
descriptions are a bit wrong. This series pertains to FSL BookE chips,
not BookE in general. There are other variants of BookE, such as 4xx.
If you could keep that in mind for future revisions, I'd appreciate
it. Something like:
[PATCH] powerpc/fsl-booke:
or something similar would be a bit more correct. Unless you really
are changing something global to all BookE processors (which is sort of
rare at the moment).
josh
next prev parent reply other threads:[~2008-12-09 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 3:34 [PATCH 1/5] powerpc: booke: Don't hard-code size of struct tlbcam Trent Piepho
2008-12-09 3:34 ` [PATCH 2/5] powerpc: booke: Remove num_tlbcam_entries Trent Piepho
2009-01-07 16:04 ` Kumar Gala
2008-12-09 3:34 ` [PATCH 3/5] powerpc: booke: Remove code duplication in lowmem mapping Trent Piepho
2009-01-07 16:13 ` Kumar Gala
2009-01-13 15:43 ` Kumar Gala
2008-12-09 3:34 ` [PATCH 4/5] powerpc: booke: Make CAM entries used for lowmem configurable Trent Piepho
2009-01-13 15:43 ` Kumar Gala
2008-12-09 3:34 ` [PATCH 5/5] powerpc: booke: Allow larger CAM sizes than 256 MB Trent Piepho
2009-01-13 15:43 ` Kumar Gala
2008-12-09 14:26 ` Josh Boyer [this message]
2009-01-07 16:17 ` [PATCH 1/5] powerpc: booke: Don't hard-code size of struct tlbcam Kumar Gala
2009-01-07 16:03 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209092649.1d262327@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=tpiepho@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).