From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC/PATCH 2/2] powerpc: 44x doesn't need G set everywhere
Date: Wed, 10 Dec 2008 08:31:43 -0500 [thread overview]
Message-ID: <20081210083143.62b869f4@zod.rchland.ibm.com> (raw)
In-Reply-To: <20081210055139.A7FFCDDF65@ozlabs.org>
On Wed, 10 Dec 2008 16:50:50 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> After discussing with chip designers, it appears that it's not
> necessary to set G everywhere on 440 cores. The various core
> errata related to prefetch should be sorted out by firmware by
> disabling icache prefetching in CCR0. We add the workaround to
> the kernel however just in case oooold firmwares don't do it.
>
> This is valid for -all- 4xx core variants. Later ones hard wire
> the absence of prefetch but it doesn't harm to clear the bits
> in CCR0 (they should already be cleared anyway).
>
> We still leave G=1 on the linear mapping for now, we need to
> stop over-mapping RAM to be able to remove it.
Hm. Over-mapping it has the nice advantage that we use as few pinned
TLB entries as possible. For 440x6 cores with more than 256 MiB of
DRAM, you could theoretically use a single 1GiB TLB entry to map all
kernel DRAM.
Do you think the trade-offs of allowing speculative accesses are worth
the increased TLB pressure? Large base pages will help with that in
some workloads, but others are still going to be TLB constrained.
I know, I'm probably paranoid. But changing things like this around
without some kind of benchmark data or testcase to make sure we aren't
making it worse gives me the heebee-geebees.
josh
next prev parent reply other threads:[~2008-12-10 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 5:50 [RFC/PATCH 2/2] powerpc: 44x doesn't need G set everywhere Benjamin Herrenschmidt
2008-12-10 13:31 ` Josh Boyer [this message]
2008-12-10 20:03 ` Benjamin Herrenschmidt
2008-12-10 20:11 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210083143.62b869f4@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).