From: Stefan Roese <sr@denx.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Grant Erickson <gerickson@nuovations.com>
Subject: Re: PPC4xx ECC Configs, Defines and Source
Date: Wed, 10 Dec 2008 10:07:16 +0100 [thread overview]
Message-ID: <200812101007.16677.sr@denx.de> (raw)
In-Reply-To: <1228899216.22413.52.camel@pasglop>
On Wednesday 10 December 2008, Benjamin Herrenschmidt wrote:
> > Why is there a need to have so many files? I would think you could
> > have a single file with all the ECC monitoring implementations in it
> > called ppc4xx_ecc.c (or such). Surely they would share some amount
> > of code?
>
> Well, it depends how much they share, but I'd rather have separate files
> with helpers in ppc4xx_soc.c if it's small, that way, it's easier to
> only build selected files based on what SoC support is enabled.
ACK. The Denali core for example from 440EPx/GRx is completely different.
Trying to fit this Denali ECC handling into the IBM-DDR(2) code would result
in an ugly mess.
Best regards,
Stefan
next prev parent reply other threads:[~2008-12-10 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 19:28 PPC4xx ECC Configs, Defines and Source Grant Erickson
2008-12-08 20:21 ` Josh Boyer
2008-12-08 22:08 ` Grant Erickson
2008-12-08 23:10 ` Josh Boyer
2008-12-08 23:40 ` Grant Erickson
2008-12-09 5:57 ` Stefan Roese
2008-12-09 6:32 ` Grant Erickson
2008-12-10 8:53 ` Benjamin Herrenschmidt
2008-12-10 9:07 ` Stefan Roese [this message]
2008-12-10 12:37 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812101007.16677.sr@denx.de \
--to=sr@denx.de \
--cc=benh@kernel.crashing.org \
--cc=gerickson@nuovations.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).