From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix build of 4xx simple platforms without CONFIG_PCI
Date: Wed, 10 Dec 2008 14:06:30 -0500 [thread overview]
Message-ID: <20081210140630.3dfaa9fd@zod.rchland.ibm.com> (raw)
In-Reply-To: <20081210092508.66e566f8@zod.rchland.ibm.com>
On Wed, 10 Dec 2008 09:25:08 -0500
Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:
> On Mon, 08 Dec 2008 16:38:14 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> >
> > > > --- linux-work.orig/arch/powerpc/platforms/40x/ppc40x_simple.c 2008-12-08 15:51:49.000000000 +1100
> > > > +++ linux-work/arch/powerpc/platforms/40x/ppc40x_simple.c 2008-12-08 15:51:52.000000000 +1100
> > > > @@ -61,7 +61,9 @@ static int __init ppc40x_probe(void)
> > > >
> > > > for (i = 0; i < ARRAY_SIZE(board); i++) {
> > > > if (of_flat_dt_is_compatible(root, board[i])) {
> > > > +#ifdef CONFIG_PCI
> > > > ppc_pci_flags = PPC_PCI_REASSIGN_ALL_RSRC;
> > > > +#endif
> > >
> > > No! #ifdefs! in C code!
> > >
> > > To the tune of you-know-what.
> > >
> > > Looks like we need an accessor we can replace with an empty version in
> > > the !PCI case.
> >
> > If you have plenty of time on your hands :-) In the meantime, this is a
> > build fix.
>
> I have time. I hate ifdefs.
Oh, and:
http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048214.html
I told you so (sort of). Ha! ;)
josh
next prev parent reply other threads:[~2008-12-10 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 4:53 [PATCH] powerpc: Fix build of 4xx simple platforms without CONFIG_PCI Benjamin Herrenschmidt
2008-12-08 5:32 ` Michael Ellerman
2008-12-08 5:38 ` Benjamin Herrenschmidt
2008-12-10 14:25 ` Josh Boyer
2008-12-10 19:06 ` Josh Boyer [this message]
2008-12-10 21:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210140630.3dfaa9fd@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).