Re: [PATCH] NOMMU: Rename PowerPC's struct vm_region

[Josh Boyer <jwboyer@linux.vnet.ibm.com>]

On Thu, 11 Dec 2008 12:53:54 +0000
David Howells <dhowells@redhat.com> wrote:

> Rename PowerPC's struct vm_region so that I can introduce my own global version
> for NOMMU.  It's feasible that the PowerPC version may wish to use my global
> one instead.
> 
> The NOMMU vm_region struct defines areas of the physical memory map that are
> under mmap.  This may include chunks of RAM or regions of memory mapped
> devices, such as flash.  It is also used to retain copies of file content so
> that shareable private memory mappings of files can be made.  As such, it may
> be compatible with what is described in the banner comment for PowerPC's
> vm_region struct.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
> 
>  arch/powerpc/lib/dma-noncoherent.c |   24 ++++++++++++------------
>  1 files changed, 12 insertions(+), 12 deletions(-)
> 
> 
> diff --git a/arch/powerpc/lib/dma-noncoherent.c b/arch/powerpc/lib/dma-noncoherent.c
> index 31734c0..a55c6ca 100644
> --- a/arch/powerpc/lib/dma-noncoherent.c
> +++ b/arch/powerpc/lib/dma-noncoherent.c
> @@ -77,26 +77,26 @@ static DEFINE_SPINLOCK(consistent_lock);
>   * the amount of RAM found at boot time.)  I would imagine that get_vm_area()
>   * would have to initialise this each time prior to calling vm_region_alloc().
>   */
> -struct vm_region {
> +struct ppc_vm_region {
>  	struct list_head	vm_list;
>  	unsigned long		vm_start;
>  	unsigned long		vm_end;
>  };
> 
> -static struct vm_region consistent_head = {
> +static struct ppc_vm_region consistent_head = {
>  	.vm_list	= LIST_HEAD_INIT(consistent_head.vm_list),
>  	.vm_start	= CONSISTENT_BASE,
>  	.vm_end		= CONSISTENT_END,
>  };
> 
> -static struct vm_region *
> -vm_region_alloc(struct vm_region *head, size_t size, gfp_t gfp)
> +static struct ppc_vm_region *
> +ppc_vm_region_alloc(struct ppc_vm_region *head, size_t size, gfp_t gfp)

Is there a reason you renamed all the function names as well when they
are static?

josh