linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
@ 2008-12-14  3:44 FUJITA Tomonori
  2008-12-15  7:28 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: FUJITA Tomonori @ 2008-12-14  3:44 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: paulus, linux-kernel, jens.axboe

This is a resend of:

http://marc.info/?l=linux-kernel&m=122482703616607&w=2

=
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition

The block layer dropped the virtual merge feature
(b8b3e16cfe6435d961f6aaebcfd52a1ff2a988c5). BIO_VMERGE_BOUNDARY
definition is meaningless now (For POWER, BIO_VMERGE_BOUNDARY has been
meaningless for a long time since POWER disables the virtual merge
feature).

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 arch/powerpc/include/asm/io.h |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
index 08266d2..494cd8b 100644
--- a/arch/powerpc/include/asm/io.h
+++ b/arch/powerpc/include/asm/io.h
@@ -713,13 +713,6 @@ static inline void * phys_to_virt(unsigned long address)
  */
 #define page_to_phys(page)	((phys_addr_t)page_to_pfn(page) << PAGE_SHIFT)
 
-/* We do NOT want virtual merging, it would put too much pressure on
- * our iommu allocator. Instead, we want drivers to be smart enough
- * to coalesce sglists that happen to have been mapped in a contiguous
- * way by the iommu
- */
-#define BIO_VMERGE_BOUNDARY	0
-
 /*
  * 32 bits still uses virt_to_bus() for it's implementation of DMA
  * mappings se we have to keep it defined here. We also have some old
-- 
1.5.5.GIT

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
  2008-12-14  3:44 [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition FUJITA Tomonori
@ 2008-12-15  7:28 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-12-15  7:28 UTC (permalink / raw)
  To: FUJITA Tomonori; +Cc: linuxppc-dev, paulus, linux-kernel

On Sun, Dec 14 2008, FUJITA Tomonori wrote:
> This is a resend of:
> 
> http://marc.info/?l=linux-kernel&m=122482703616607&w=2
> 
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
> 
> The block layer dropped the virtual merge feature
> (b8b3e16cfe6435d961f6aaebcfd52a1ff2a988c5). BIO_VMERGE_BOUNDARY
> definition is meaningless now (For POWER, BIO_VMERGE_BOUNDARY has been
> meaningless for a long time since POWER disables the virtual merge
> feature).
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Acked-by: Jens Axboe <jens.axboe@oracle.com>

> ---
>  arch/powerpc/include/asm/io.h |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
> index 08266d2..494cd8b 100644
> --- a/arch/powerpc/include/asm/io.h
> +++ b/arch/powerpc/include/asm/io.h
> @@ -713,13 +713,6 @@ static inline void * phys_to_virt(unsigned long address)
>   */
>  #define page_to_phys(page)	((phys_addr_t)page_to_pfn(page) << PAGE_SHIFT)
>  
> -/* We do NOT want virtual merging, it would put too much pressure on
> - * our iommu allocator. Instead, we want drivers to be smart enough
> - * to coalesce sglists that happen to have been mapped in a contiguous
> - * way by the iommu
> - */
> -#define BIO_VMERGE_BOUNDARY	0
> -
>  /*
>   * 32 bits still uses virt_to_bus() for it's implementation of DMA
>   * mappings se we have to keep it defined here. We also have some old
> -- 
> 1.5.5.GIT
> 

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-15  7:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-14  3:44 [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition FUJITA Tomonori
2008-12-15  7:28 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).