[PATCH] [RFC] Pass a valid token to rats_call() in phyp-dump code.

[PATCH] [RFC] Pass a valid token to rats_call() in phyp-dump code.

[Tony Breeds]

ibm_configure_kernel_dump, is passed as the token to rtas_call() but I
cannot see where it is initialised.  Set it to something sane?

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
 arch/powerpc/platforms/pseries/phyp_dump.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/phyp_dump.c b/arch/powerpc/platforms/pseries/phyp_dump.c
index 16e659a..6cf35cd 100644
--- a/arch/powerpc/platforms/pseries/phyp_dump.c
+++ b/arch/powerpc/platforms/pseries/phyp_dump.c
@@ -414,6 +414,8 @@ static int __init phyp_dump_setup(void)
 		of_node_put(rtas);
 	}
 
+	ibm_configure_kernel_dump = rtas_token("ibm,configure-kernel-dump");
+
 	print_dump_header(dump_header);
 	dump_area_length = init_dump_header(&phdr);
 	/* align down */
-- 
1.6.0.4


Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!

Re: [PATCH] [RFC] Pass a valid token to rats_call() in phyp-dump code.

[Nathan Lynch]

Tony Breeds wrote:
> ibm_configure_kernel_dump, is passed as the token to rtas_call() but I
> cannot see where it is initialised.  Set it to something sane?

Yes, please.

Acked-by: Nathan Lynch <ntl@pobox.com>

Would be good to know whether the dump area registration and dump
retrieval are working with your changes.  Doesn't look like they could
have worked at all with this bug.

Re: [PATCH] [RFC] Pass a valid token to rats_call() in phyp-dump code.

[Manish Ahuja]

Yes,

That is required. It is in the patches that I sent to Ben, Paul & Brad.

I just waiting to post it with other patches.

Acked-by: Manish Ahuja <mahujam@gmail.com>

Tony Breeds wrote:
> ibm_configure_kernel_dump, is passed as the token to rtas_call() but I
> cannot see where it is initialised.  Set it to something sane?
> 
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
>  arch/powerpc/platforms/pseries/phyp_dump.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/phyp_dump.c b/arch/powerpc/platforms/pseries/phyp_dump.c
> index 16e659a..6cf35cd 100644
> --- a/arch/powerpc/platforms/pseries/phyp_dump.c
> +++ b/arch/powerpc/platforms/pseries/phyp_dump.c
> @@ -414,6 +414,8 @@ static int __init phyp_dump_setup(void)
>  		of_node_put(rtas);
>  	}
>  
> +	ibm_configure_kernel_dump = rtas_token("ibm,configure-kernel-dump");
> +
>  	print_dump_header(dump_header);
>  	dump_area_length = init_dump_header(&phdr);
>  	/* align down */


-- 

--
Manish Ahuja
Linux RAS Engineer.
IBM Linux Technology Center
mahuja@us.ibm.com
512-838-1928, t/l 678-1928.

Re: [PATCH] [RFC] Pass a valid token to rats_call() in phyp-dump code.

[Josh Boyer]

On Tue, Dec 16, 2008 at 03:34:43PM +1100, Tony Breeds wrote:
>ibm_configure_kernel_dump, is passed as the token to rtas_call() but I
>cannot see where it is initialised.  Set it to something sane?
>
>Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>

Seems sane as a fix, just a note that whoever needs to apply this
patch should fix the Subject line to say "rtas" and not "rats".

Though rats is applicable at times :)

josh