From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by ozlabs.org (Postfix) with ESMTP id F1408DDF26 for ; Thu, 18 Dec 2008 19:04:29 +1100 (EST) From: Stefan Roese To: linuxppc-dev@ozlabs.org Subject: Re: [PATCH v2] powerpc/4xx: DTS: Add Add'l SDRAM0 Compatible and Interrupt Info Date: Thu, 18 Dec 2008 09:04:23 +0100 References: <1229563900-10447-1-git-send-email-gerickson@nuovations.com> In-Reply-To: <1229563900-10447-1-git-send-email-gerickson@nuovations.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200812180904.23593.sr@denx.de> Cc: bluesmoke-devel@lists.sourceforge.net, Grant Erickson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thursday 18 December 2008, Grant Erickson wrote: > Added additional information for type and compatibility strings and > interrupt information to the SDRAM0 memory-controller device tree > nodes for AMCC PowerPC 405EX[r]-based boards to facilitate binding > with the new "ibm,sdram-4xx-ddr2" EDAC memory controller adapter driver. > > Signed-off-by: Grant Erickson > --- > As support in the associated EDAC adapter driver is added over time, > similar changes will/should be made to the DTS files for boards > leveraging realizations of this "ibm,sdram-4xx-ddr2" controller, > including the 440SP, 440SPe, 460EX, 460GT and 460SX. > > Patch v2, based on review from David Gibson, removes the 'device_type' > field because it is only used for legacy OpenFirmware method > interfaces and no such compatibility is warranted here. In addition, > removed address- and size-cells as this node has no children. > > arch/powerpc/boot/dts/haleakala.dts | 8 +- > arch/powerpc/boot/dts/kilauea.dts | 8 +- > arch/powerpc/boot/dts/makalu.dts | 8 +- > 3 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/boot/dts/haleakala.dts > b/arch/powerpc/boot/dts/haleakala.dts index 513bc43..64880ab 100644 > --- a/arch/powerpc/boot/dts/haleakala.dts > +++ b/arch/powerpc/boot/dts/haleakala.dts > @@ -89,8 +89,14 @@ > clock-frequency = <0>; /* Filled in by U-Boot */ > > SDRAM0: memory-controller { > - compatible = "ibm,sdram-405exr"; > + compatible = "ibm,sdram-405exr", "ibm,sdram-4xx-ddr2"; > dcr-reg = <0x010 0x002>; > + #interrupt-cells = <1>; > + interrupt-parent = <&SDRAM0>; > + interrupts = <0x0 0x1>; > + interrupt-map = + /* ECCSEC Error */ 0x1 &UIC2 0x6 0x4>; > + interrupt-map-mask = <0xffffffff>; When all interrupts are mapped the same parent, this should do as well: interrupt-parent = <&UIC2>; interrupts = <0x5 0x4 /* ECCDED Error */ 0x6 0x4>; /* ECCSEC Error */ Other than this: Acked-by: Stefan Roese Thanks. Best regards, Stefan