From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Timur Tabi <timur@freescale.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
Andy Fleming <afleming@freescale.com>,
Li Yang <leoli@freescale.com>, Jeff Garzik <jgarzik@pobox.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/6] ucc_geth: Fix TX watchdog timeout handling
Date: Sun, 21 Dec 2008 06:37:41 +0300 [thread overview]
Message-ID: <20081221033741.GB3885@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <ed82fe3e0812201919o619fd7e7jb87bbec551caa4d@mail.gmail.com>
On Sat, Dec 20, 2008 at 09:19:23PM -0600, Timur Tabi wrote:
> On Thu, Dec 18, 2008 at 12:23 PM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > +static int ucc_geth_close(struct net_device *dev);
> > +static int ucc_geth_open(struct net_device *dev);
>
> I would prefer that you reorder the functions to eliminate the need
> for forward references.
I'll post a cleanup patch (0/6 series is already in the netdev tree).
Thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2008-12-21 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 18:23 [PATCH 2/6] ucc_geth: Fix TX watchdog timeout handling Anton Vorontsov
2008-12-21 3:19 ` Timur Tabi
2008-12-21 3:37 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081221033741.GB3885@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).