From: Grant Likely <grant.likely@secretlab.ca>
To: linuxppc-dev@ozlabs.org, hans.lehmann@ritter-elektronik.de,
matt@genesi-usa.com, olaf@aepfle.de
Subject: [PATCH 2/4] powerpc/mpc5200: Bestcomm fixes to ATA support
Date: Sun, 21 Dec 2008 01:06:25 -0700 [thread overview]
Message-ID: <20081221080624.29029.9108.stgit@localhost.localdomain> (raw)
In-Reply-To: <20081221080213.29029.7646.stgit@localhost.localdomain>
From: Tim Yamin <plasm@roo.me.uk>
1) ata.h has dst_pa in the wrong place (needs to match what the BestComm
task microcode in bcom_ata_task.c expects); fix it.
2) The BestComm ATA task priority was changed to maximum in bestcomm_priv.h;
this fixes a deadlock issue experienced with heavy DMA occurring on
both the ATA and Ethernet BestComm tasks, e.g. when downloading a large
file over a LAN to disk.
Signed-off-by: Tim Yamin <plasm@roo.me.uk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/sysdev/bestcomm/ata.h | 2 +-
arch/powerpc/sysdev/bestcomm/bestcomm_priv.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/sysdev/bestcomm/ata.h b/arch/powerpc/sysdev/bestcomm/ata.h
index 1098276..0374322 100644
--- a/arch/powerpc/sysdev/bestcomm/ata.h
+++ b/arch/powerpc/sysdev/bestcomm/ata.h
@@ -16,8 +16,8 @@
struct bcom_ata_bd {
u32 status;
- u32 dst_pa;
u32 src_pa;
+ u32 dst_pa;
};
extern struct bcom_task *
diff --git a/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h b/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
index 866a291..746f155 100644
--- a/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
+++ b/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
@@ -198,8 +198,8 @@ struct bcom_task_header {
#define BCOM_IPR_SCTMR_1 2
#define BCOM_IPR_FEC_RX 6
#define BCOM_IPR_FEC_TX 5
-#define BCOM_IPR_ATA_RX 4
-#define BCOM_IPR_ATA_TX 3
+#define BCOM_IPR_ATA_RX 7
+#define BCOM_IPR_ATA_TX 7
#define BCOM_IPR_SCPCI_RX 2
#define BCOM_IPR_SCPCI_TX 2
#define BCOM_IPR_PSC3_RX 2
next prev parent reply other threads:[~2008-12-21 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 8:06 [PATCH 0/4] powerpc/mpc5200: Add support for ATA DMA Grant Likely
2008-12-21 8:06 ` [PATCH 1/4] powerpc/mpc5200: Bugfix on handling variable sized buffer descriptors Grant Likely
2008-12-21 8:06 ` Grant Likely [this message]
2008-12-21 8:06 ` [PATCH 3/4] powerpc/mpc5200: Disable bestcomm prefetching when ATA DMA enabled Grant Likely
2008-12-21 8:06 ` [PATCH 4/4] powerpc/mpc5200: Add MDMA/UDMA support to MPC5200 ATA driver Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081221080624.29029.9108.stgit@localhost.localdomain \
--to=grant.likely@secretlab.ca \
--cc=hans.lehmann@ritter-elektronik.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@genesi-usa.com \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).