linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/iseries: Kexec is known not to work on iseries
Date: Tue, 23 Dec 2008 12:50:51 -0600	[thread overview]
Message-ID: <20081223185051.GX6958@localdomain> (raw)
In-Reply-To: <102d4cdd8493017c104fda0dccc513bce056430c.1230024187.git.michael@ellerman.id.au>

Hi,

Michael Ellerman wrote:
> The non-zero return from the prepare callback is returned by sys_kexec_load()
> to userspace, indicating that kexec is not supported on the machine.

...

> @@ -638,6 +639,13 @@ static int __init iseries_probe(void)
>  	return 1;
>  }
>  
> +#ifdef CONFIG_KEXEC
> +static int iseries_kexec_prepare(struct kimage *image)
> +{
> +	return -ENOSYS;
> +}
> +#endif
> +
>  define_machine(iseries) {
>  	.name			= "iSeries",
>  	.setup_arch		= iSeries_setup_arch,
> @@ -658,6 +666,9 @@ define_machine(iseries) {
>  	.probe			= iseries_probe,
>  	.ioremap		= iseries_ioremap,
>  	.iounmap		= iseries_iounmap,
> +#ifdef CONFIG_KEXEC
> +	.machine_kexec_prepare	= iseries_kexec_prepare,
> +#endif
>  	/* XXX Implement enable_pmcs for iSeries */
>  };

But machine_kexec_prepare() already returns -ENOSYS if the platform
doesn't have the hook in ppc_md.  I must be missing something; what is
this patch fixing?

  reply	other threads:[~2008-12-23 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-23  9:23 [PATCH] powerpc/iseries: Kexec is known not to work on iseries Michael Ellerman
2008-12-23 18:50 ` Nathan Lynch [this message]
2008-12-23 19:12   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081223185051.GX6958@localdomain \
    --to=ntl@pobox.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).