From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibmveth: use consistent types
Date: Tue, 30 Dec 2008 21:49:59 -0800 (PST) [thread overview]
Message-ID: <20081230.214959.141224132.davem@davemloft.net> (raw)
In-Reply-To: <20081231140225.48b695ef.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 31 Dec 2008 14:02:25 +1100
> These variables are only used with an interface involving "unsigned
> long" and the macros are only used with these variables. This change
> will prevent some warnings when we change u64 to "unsigned long long".
>
> This code is only built for 64bit powerpc, so the transformation is
> really a noop.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
I'd prefer if the types were to remain 32-bit portable.
Doing things like this is just a problem waiting to happen,
either for the first person who actually finds a need and
a way to use this driver on 32-bit or the person who cut and
pastes this code into their driver which should work on both
32-bit and 64-bit.
Patch not applied.
next prev parent reply other threads:[~2008-12-31 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 3:02 [PATCH] ibmveth: use consistent types Stephen Rothwell
2008-12-31 5:49 ` David Miller [this message]
2008-12-31 9:06 ` Benjamin Herrenschmidt
2009-01-06 5:39 ` Stephen Rothwell
2009-01-06 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081230.214959.141224132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).