linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: tklein@de.ibm.com, netdev@vger.kernel.org, raisch@de.ibm.com,
	themann@de.ibm.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] net/ehea: bitops work on unsigned longs
Date: Mon, 05 Jan 2009 16:05:35 -0800 (PST)	[thread overview]
Message-ID: <20090105.160535.24967514.davem@davemloft.net> (raw)
In-Reply-To: <20090106105951.62b0429d.sfr@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 6 Jan 2009 10:59:51 +1100

> Hi Dave,
> 
> On Tue, 30 Dec 2008 21:51:56 -0800 (PST) David Miller <davem@davemloft.net> wrote:
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 31 Dec 2008 14:18:53 +1100
> > 
> > > These changes will avoid several warnings when we change u64 to unsigned
> > > long long.
> > > 
> > > Also, ehea_driver_flags is only used in ehca_main.c
> > > 
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > 
> > And also rejected, just like the previous two.
> > 
> > This is so much worse than the problems we had with
> > printing u64's and it's being done as a result to
> > the "fix" for that.
> 
> How is this worse than anything?  The only thing wrong with this patch is
> the commit message ... Lets try this (if this doesn't address your
> problems, then assume I am too dense for your original explanation):

Aha, yes the commit message fooled me :-)  New patch is fine and
I'll toss this into net-2.6

  reply	other threads:[~2009-01-06  0:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-31  3:18 [PATCH] net/ehea: bitops work on unsigned longs Stephen Rothwell
2008-12-31  5:51 ` David Miller
2008-12-31  9:02   ` Benjamin Herrenschmidt
2009-01-05 23:59   ` Stephen Rothwell
2009-01-06  0:05     ` David Miller [this message]
2009-01-06  0:11       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090105.160535.24967514.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=raisch@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=themann@de.ibm.com \
    --cc=tklein@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).