From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibmveth: use consistent types
Date: Tue, 06 Jan 2009 10:47:53 -0800 (PST) [thread overview]
Message-ID: <20090106.104753.91462944.davem@davemloft.net> (raw)
In-Reply-To: <20090106163908.2e6134f4.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 6 Jan 2009 16:39:08 +1100
> These variables are only used with an interface that just dumps their
> values into registers to be passed to the hypervisor. The arguments
> to that interface are declared to be "unsigned long", so make these
> variables match. The macros are only used with these variables, so make
> them match as well.
>
> This code is currently only built for 64bit powerpc, so the transformation
> is really a noop. If the interface was ever ported to 32 bit, it would
> almost certainly still use registers to pass the parameters and so
> "unsigned long" would still be appropriate.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Also applied, thanks Stephen.
prev parent reply other threads:[~2009-01-06 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 3:02 [PATCH] ibmveth: use consistent types Stephen Rothwell
2008-12-31 5:49 ` David Miller
2008-12-31 9:06 ` Benjamin Herrenschmidt
2009-01-06 5:39 ` Stephen Rothwell
2009-01-06 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106.104753.91462944.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).