From: Sam Ravnborg <sam@ravnborg.org>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-ppc <linuxppc-dev@ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Milton Miller <miltonm@bga.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Date: Tue, 6 Jan 2009 17:40:06 +0100 [thread overview]
Message-ID: <20090106164006.GA15934@uranus.ravnborg.org> (raw)
In-Reply-To: <20090106155724.GA6747@linux.vnet.ibm.com>
On Tue, Jan 06, 2009 at 09:27:24PM +0530, Kamalesh Babulal wrote:
> * Sam Ravnborg <sam@ravnborg.org> [2009-01-06 11:46:19]:
>
> > Hi Kamalesh
> >
> > Looks good, small nit below.
> >
> > > config VIOPATH
> > > bool
> > > - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
> > > - default y
> > > + default n
> >
> > As 'n' is default anyway this line is not needed and I suggest you
> > spin a final version of the patch with this removed.
> >
> > Sam
>
> Hi Sam,
>
> Thanks for the review comments. I am resending the patch with the changes
> you have recommended.
>
> Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
>
> iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled.
> Removing the dependency of VIOPATH by selecting it, when the drivers
> dependent on iSeries code.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2009-01-06 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 8:54 [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH Milton Miller
2009-01-04 12:12 ` Stephen Rothwell
2009-01-04 18:24 ` Kamalesh Babulal
2009-01-05 13:33 ` Milton Miller
2009-01-06 7:25 ` Kamalesh Babulal
2009-01-06 7:31 ` Sam Ravnborg
2009-01-06 9:38 ` Kamalesh Babulal
2009-01-06 10:46 ` Sam Ravnborg
2009-01-06 15:57 ` Kamalesh Babulal
2009-01-06 16:40 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-03 19:13 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106164006.GA15934@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).