From: Nathan Lynch <ntl@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH/RFC] sysfs cache code rewrite
Date: Wed, 7 Jan 2009 03:46:11 -0600 [thread overview]
Message-ID: <20090107094611.GD7376@localdomain> (raw)
In-Reply-To: <1231311324.14860.81.camel@pasglop>
Benjamin Herrenschmidt wrote:
>
> > I don't know quite the detail of the new cpumask stuff ... It could be
> > as simple as passing a pointer instead of the value in the
> > cpumask_scnprintf call though...
>
> Actually, I'll do more tests and if that ends up being the only needed
> change, I'll push your patch with that small change out to powerpc next
> tonight.
Sorry about that, here's an incremental... let me know if you want the
whole thing re-posted.
Thanks.
diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c
index f3e3ae3..b33f041 100644
--- a/arch/powerpc/kernel/cacheinfo.c
+++ b/arch/powerpc/kernel/cacheinfo.c
@@ -611,7 +611,7 @@ static ssize_t shared_cpu_map_show(struct kobject *k, struct kobj_attribute *att
len = PAGE_SIZE - 2;
if (len > 1) {
- n = cpumask_scnprintf(buf, len, cache->shared_cpu_map);
+ n = cpumask_scnprintf(buf, len, &cache->shared_cpu_map);
buf[n++] = '\n';
buf[n] = '\0';
}
next prev parent reply other threads:[~2009-01-07 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 4:55 [PATCH/RFC] sysfs cache code rewrite Nathan Lynch
2009-01-06 21:25 ` Nathan Lynch
2009-01-07 6:51 ` Benjamin Herrenschmidt
2009-01-07 6:55 ` Benjamin Herrenschmidt
2009-01-07 9:46 ` Nathan Lynch [this message]
2009-01-07 10:15 ` Benjamin Herrenschmidt
2009-01-07 18:48 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107094611.GD7376@localdomain \
--to=ntl@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).