From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix missing semicolons in mmu_decl.h
Date: Wed, 7 Jan 2009 09:37:24 -0500 [thread overview]
Message-ID: <20090107143724.GF17171@zod.rchland.ibm.com> (raw)
In-Reply-To: <20090107035702.C9114474D7@ozlabs.org>
On Wed, Jan 07, 2009 at 02:56:51PM +1100, Benjamin Herrenschmidt wrote:
>This is a brown paper bag from one of my earlier patches that
>breaks build on 40x and 8xx.
>
>And yes, I've now added 40x and 8xx to my list of test configs :-)
>
>Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Please get it into your tree so people stop emailing me about it
being broken :).
josh
>---
>
> arch/powerpc/mm/mmu_decl.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>--- linux-work.orig/arch/powerpc/mm/mmu_decl.h 2009-01-07 14:52:33.000000000 +1100
>+++ linux-work/arch/powerpc/mm/mmu_decl.h 2009-01-07 14:52:43.000000000 +1100
>@@ -30,11 +30,11 @@
> #if defined(CONFIG_40x) || defined(CONFIG_8xx)
> static inline void _tlbil_all(void)
> {
>- asm volatile ("sync; tlbia; isync" : : : "memory")
>+ asm volatile ("sync; tlbia; isync" : : : "memory");
> }
> static inline void _tlbil_pid(unsigned int pid)
> {
>- asm volatile ("sync; tlbia; isync" : : : "memory")
>+ asm volatile ("sync; tlbia; isync" : : : "memory");
> }
> #else /* CONFIG_40x || CONFIG_8xx */
> extern void _tlbil_all(void);
>@@ -47,7 +47,7 @@ extern void _tlbil_pid(unsigned int pid)
> #ifdef CONFIG_8xx
> static inline void _tlbil_va(unsigned long address, unsigned int pid)
> {
>- asm volatile ("tlbie %0; sync" : : "r" (address) : "memory")
>+ asm volatile ("tlbie %0; sync" : : "r" (address) : "memory");
> }
> #else /* CONFIG_8xx */
> extern void _tlbil_va(unsigned long address, unsigned int pid);
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@ozlabs.org
>https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2009-01-07 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 3:56 [PATCH] powerpc: Fix missing semicolons in mmu_decl.h Benjamin Herrenschmidt
2009-01-07 14:37 ` Josh Boyer [this message]
2009-01-07 20:51 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107143724.GF17171@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).