linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sean MacLennan <smaclennan@pikatech.com>
To: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: mal_probe crash
Date: Wed, 7 Jan 2009 15:44:34 -0500	[thread overview]
Message-ID: <20090107154434.0c9437ef@lappy.seanm.ca> (raw)

With Linus' latest git, mal_probe crashes. It calls netif_napi_add with
the first parameter NULL. This was ok since the parameter, a net
device, was only used if CONFIG_NETPOLL was set.

Now it is always de-referenced. A quick check shows that ibm_newemac is
the only driver that passed NULL as the first parameter to this call in
2.6.28.

I don't really follow ibm_newemac changes, so the patch may be waiting
to be applied. This is really just a heads up.

Cheers,
   Sean

             reply	other threads:[~2009-01-07 20:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 20:44 Sean MacLennan [this message]
2009-01-08 20:46 ` mal_probe crash Josh Boyer
2009-01-07 22:50   ` Benjamin Herrenschmidt
2009-01-09 14:42     ` Geert Uytterhoeven
2009-01-09 22:34       ` Herbert Xu
2009-01-09 23:13         ` Benjamin Herrenschmidt
2009-01-09 14:49     ` Matthias Fuchs
2009-01-09 15:02       ` Matthias Fuchs
2009-01-09 15:24         ` Geert Uytterhoeven
2009-01-09 21:30           ` Benjamin Herrenschmidt
2009-01-09 22:01             ` Roland Dreier
2009-01-12 13:37               ` Geert Uytterhoeven
2009-01-12 21:36                 ` Benjamin Herrenschmidt
2009-01-12 22:48                   ` Josh Boyer
2009-01-12 22:51                   ` Re[2]: " Yuri Tikhonov
2009-01-13  2:52                     ` Benjamin Herrenschmidt
2009-01-13 16:19                     ` Geert Uytterhoeven
2009-01-09 21:09       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090107154434.0c9437ef@lappy.seanm.ca \
    --to=smaclennan@pikatech.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).