From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Liu Dave <DaveLiu@freescale.com>
Cc: Huang Changming-R66093 <Chang-Ming.Huang@freescale.com>,
Phillips Kim-R1AAHA <Kim.Phillips@freescale.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC modesupport
Date: Thu, 8 Jan 2009 23:59:51 +0300 [thread overview]
Message-ID: <20090108205951.GA24829@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <D7CCA83BB0796C49BC0BB53B6AB12089056CC6@zch01exm21.fsl.freescale.net>
On Thu, Jan 08, 2009 at 03:27:10PM +0800, Liu Dave wrote:
> > +static void __iomem *mpc83xx_pcie_remap_cfg(struct pci_bus *bus,
> > + unsigned int devfn,
>
> [snip]
>
> > + if (pcie->dev_base == dev_base)
> > + goto mapped;
> > +
> > + out_le32(hose->cfg_data + PEX_OUTWIN0_TAL, dev_base);
> > +
> > + pcie->dev_base = dev_base;
>
> Do we need local_irq_save/local_irq_restore between them?
No, I don't think we need it. drivers/pci/access.c hold an
irqsave spinlock for ->read and ->write callbacks.
> out_le32(PEX_OUTWIN0_TAL,...) and pcie->dev_base = dev_base;
> > +mapped:
> > + return pcie->cfg_map + offset;
> > +}
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-01-08 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 1:30 [PATCH v5 0/2] MPC83xx PCI-E support Anton Vorontsov
2009-01-08 1:31 ` [PATCH 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC mode support Anton Vorontsov
2009-01-08 6:50 ` Kumar Gala
2009-01-08 19:10 ` Anton Vorontsov
2009-01-08 19:24 ` Kumar Gala
2009-01-08 21:55 ` [PATCH v6 " Anton Vorontsov
2009-01-09 0:17 ` Kumar Gala
2009-01-08 7:27 ` [PATCH 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC modesupport Liu Dave
2009-01-08 20:59 ` Anton Vorontsov [this message]
2009-01-08 1:31 ` [PATCH 2/2] powerpc/83xx: Add PCI-E support for all MPC83xx boards with PCI-E Anton Vorontsov
2009-01-09 0:17 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108205951.GA24829@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=Chang-Ming.Huang@freescale.com \
--cc=DaveLiu@freescale.com \
--cc=Kim.Phillips@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).