From: David Miller <davem@davemloft.net>
To: timur@freescale.com
Cc: netdev@vger.kernel.org, leoli@freescale.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ucc_geth: use correct UCCE macros
Date: Sun, 11 Jan 2009 00:25:45 -0800 (PST) [thread overview]
Message-ID: <20090111.002545.208618220.davem@davemloft.net> (raw)
In-Reply-To: <1231359172-6119-1-git-send-email-timur@freescale.com>
From: Timur Tabi <timur@freescale.com>
Date: Wed, 7 Jan 2009 14:12:52 -0600
> The UCC Event Register (UCCE) already has unambigous macro definitions in qe.h,
> so we should not be defining our own in the UCC Ethernet driver.
>
> Removed unused local variable 'dev' from ucc_geth_poll(), which fixes a warning
> caused by commit 908a7a16b852ffd618a9127be8d62432182d81b4.
>
> Replaced in_be/out_be pairs with setbits32 or clrbits32, where applicable.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Applied.
prev parent reply other threads:[~2009-01-11 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 20:12 [PATCH] ucc_geth: use correct UCCE macros Timur Tabi
2009-01-07 20:17 ` Timur Tabi
2009-01-08 19:18 ` David Miller
2009-01-08 19:20 ` Timur Tabi
2009-01-11 8:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111.002545.208618220.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).