linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots
Date: Sun, 11 Jan 2009 18:30:13 +0300	[thread overview]
Message-ID: <20090111153013.GA31791@oksana.dev.rtsoft.ru> (raw)

FSL U-Boots use /soc8315@e0000000 node to search and fixup serial
nodes' clock-frequency properties. Though in upstream kernels we use
new naming convention -- for IMMR address space dts files specify
/immr@e0000000 nodes.

This makes FSL U-Boots fail to fixup the clock frequencies, and that
leads to serial ports misbehaviour. We can workaround the issue by
filling the clock frequency values manually.

p.s. For the same reason FSL U-Boots fail to fixup MAC addresses for
ethernet nodes, so users should either change the .dts file locally
or set MAC address via `ifconfig hw ether' command.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---

Leon,

With this patch 2.6.28 kernel boots and works fine with the U-Boot
I took from this image (downloadable from freescale.com):

$ md5sum MPC8315ERDB_20080321-ltib.iso
009730826366d593347b88fa4fdb9be0  MPC8315ERDB_20080321-ltib.iso

That is, U-Boot 1.3.0-rc2 (Mar 21 2008 - 13:36:09) MPC83XX

 arch/powerpc/boot/dts/mpc8315erdb.dts |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/boot/dts/mpc8315erdb.dts
index 9a4fa2a..88d691c 100644
--- a/arch/powerpc/boot/dts/mpc8315erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
@@ -257,7 +257,7 @@
 			device_type = "serial";
 			compatible = "ns16550";
 			reg = <0x4500 0x100>;
-			clock-frequency = <0>;
+			clock-frequency = <133333333>;
 			interrupts = <9 0x8>;
 			interrupt-parent = <&ipic>;
 		};
@@ -267,7 +267,7 @@
 			device_type = "serial";
 			compatible = "ns16550";
 			reg = <0x4600 0x100>;
-			clock-frequency = <0>;
+			clock-frequency = <133333333>;
 			interrupts = <10 0x8>;
 			interrupt-parent = <&ipic>;
 		};
-- 
1.5.6.5

             reply	other threads:[~2009-01-11 15:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 15:30 Anton Vorontsov [this message]
2009-01-12  7:55 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots Li Yang
2009-01-12 15:07   ` Kumar Gala
2009-01-12 17:20     ` Leon Woestenberg
2009-01-12 18:59       ` Kumar Gala
2009-01-13  5:52     ` Li Yang
2009-01-12 15:10 ` [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090111153013.GA31791@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).