From: David Miller <davem@davemloft.net>
To: Geert.Uytterhoeven@sonycom.com
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Add init_dummy_netdev() and fix EMAC driver using it
Date: Wed, 14 Jan 2009 21:05:14 -0800 (PST) [thread overview]
Message-ID: <20090114.210514.257703205.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0901141057110.31703@vixen.sonytel.be>
From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Date: Wed, 14 Jan 2009 11:00:05 +0100 (CET)
> On Wed, 14 Jan 2009, Benjamin Herrenschmidt wrote:
> > This adds an init_dummy_netdev() function that gets a network device
> > structure (allocation and lifetime entirely under caller's control) and
> > initialize the minimum amount of fields so it can be used to schedule
> > NAPI polls without registering a full blown interface. This is to be
> > used by drivers that need to tie several hardware interfaces to a single
> > NAPI poll scheduler due to HW limitations.
> >
> > It also updates the ibm_newemac driver to use that, this fixing the
> > oops on 2.6.29 due to passing NULL as "dev" to netif_napi_add()
> >
> > Symbol is exported GPL only a I don't think we want binary drivers doing
> > that sort of acrobatics (if we want them at all).
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Thanks, this fixed my Sequoia!
>
> Tested-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Applied, thanks everyone.
prev parent reply other threads:[~2009-01-15 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 4:14 [PATCH] Add init_dummy_netdev() and fix EMAC driver using it Benjamin Herrenschmidt
2009-01-14 10:00 ` Geert Uytterhoeven
2009-01-15 5:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114.210514.257703205.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).