From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sunset.davemloft.net (unknown [74.93.104.97]) by ozlabs.org (Postfix) with ESMTP id A9634DE210 for ; Thu, 15 Jan 2009 16:05:13 +1100 (EST) Date: Wed, 14 Jan 2009 21:05:14 -0800 (PST) Message-Id: <20090114.210514.257703205.davem@davemloft.net> To: Geert.Uytterhoeven@sonycom.com Subject: Re: [PATCH] Add init_dummy_netdev() and fix EMAC driver using it From: David Miller In-Reply-To: References: <1231906495.22571.79.camel@pasglop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Geert Uytterhoeven Date: Wed, 14 Jan 2009 11:00:05 +0100 (CET) > On Wed, 14 Jan 2009, Benjamin Herrenschmidt wrote: > > This adds an init_dummy_netdev() function that gets a network device > > structure (allocation and lifetime entirely under caller's control) and > > initialize the minimum amount of fields so it can be used to schedule > > NAPI polls without registering a full blown interface. This is to be > > used by drivers that need to tie several hardware interfaces to a single > > NAPI poll scheduler due to HW limitations. > > > > It also updates the ibm_newemac driver to use that, this fixing the > > oops on 2.6.29 due to passing NULL as "dev" to netif_napi_add() > > > > Symbol is exported GPL only a I don't think we want binary drivers doing > > that sort of acrobatics (if we want them at all). > > > > Signed-off-by: Benjamin Herrenschmidt > > Thanks, this fixed my Sequoia! > > Tested-by: Geert Uytterhoeven Applied, thanks everyone.