From: David Miller <davem@davemloft.net>
To: tklein@de.ibm.com
Cc: jeff@garzik.org, themann@de.ibm.com, netdev@vger.kernel.org,
hering2@de.ibm.com, linux-kernel@vger.kernel.org,
raisch@de.ibm.com, linuxppc-dev@ozlabs.org, ossthema@de.ibm.com
Subject: Re: [PATCH 3/3] ehea: Improve driver behaviour in low mem conditions
Date: Wed, 21 Jan 2009 14:47:22 -0800 (PST) [thread overview]
Message-ID: <20090121.144722.52306013.davem@davemloft.net> (raw)
In-Reply-To: <200901211549.41352.tklein@de.ibm.com>
From: Thomas Klein <tklein@de.ibm.com>
Date: Wed, 21 Jan 2009 15:49:41 +0100
> Reworked receive queue fill policies to make the driver more tolerant
> in low memory conditions.
>
> Signed-off-by: Thomas Klein <tklein@de.ibm.com>
Applied, but there is an even better way to handle this.
You should be allocating replacement RX skbs at receive time. And if
the RX allocation fails, you simply give the RX skb back to the chip
and do not pass it up into the stack.
This is what many ethernet drivers do to ensure that the chip never
can reach a situation where the free RX packet queue becomes empty.
prev parent reply other threads:[~2009-01-21 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 14:49 [PATCH 3/3] ehea: Improve driver behaviour in low mem conditions Thomas Klein
2009-01-21 22:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090121.144722.52306013.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hering2@de.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).