linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion
@ 2009-01-21  0:16 Stephen Rothwell
  2009-01-21  0:46 ` Arnd Bergmann
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Stephen Rothwell @ 2009-01-21  0:16 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Nick Spence, Olof, Johansson, Doug, linuxppc-dev,
	Egor Martovetsky, Paul Mackerras, Thompson, Scott Wood, linux-mtd,
	David Woodhouse, bluesmoke-devel

These are all powerpc specific drivers.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/edac/cell_edac.c         |    8 ++++----
 drivers/mtd/nand/fsl_elbc_nand.c |    6 +++---
 drivers/mtd/nand/pasemi_nand.c   |    4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

If noone minds (seeing as how simple this patch is) we could just merge
it via the powerpc tree.

diff --git a/drivers/edac/cell_edac.c b/drivers/edac/cell_edac.c
index cd2e3b8..24f3ca8 100644
--- a/drivers/edac/cell_edac.c
+++ b/drivers/edac/cell_edac.c
@@ -36,7 +36,7 @@ static void cell_edac_count_ce(struct mem_ctl_info *mci, int chan, u64 ar)
 	struct csrow_info		*csrow = &mci->csrows[0];
 	unsigned long			address, pfn, offset, syndrome;
 
-	dev_dbg(mci->dev, "ECC CE err on node %d, channel %d, ar = 0x%016lx\n",
+	dev_dbg(mci->dev, "ECC CE err on node %d, channel %d, ar = 0x%016llx\n",
 		priv->node, chan, ar);
 
 	/* Address decoding is likely a bit bogus, to dbl check */
@@ -58,7 +58,7 @@ static void cell_edac_count_ue(struct mem_ctl_info *mci, int chan, u64 ar)
 	struct csrow_info		*csrow = &mci->csrows[0];
 	unsigned long			address, pfn, offset;
 
-	dev_dbg(mci->dev, "ECC UE err on node %d, channel %d, ar = 0x%016lx\n",
+	dev_dbg(mci->dev, "ECC UE err on node %d, channel %d, ar = 0x%016llx\n",
 		priv->node, chan, ar);
 
 	/* Address decoding is likely a bit bogus, to dbl check */
@@ -169,7 +169,7 @@ static int __devinit cell_edac_probe(struct platform_device *pdev)
 
 	/* Get channel population */
 	reg = in_be64(&regs->mic_mnt_cfg);
-	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
+	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016llx\n", reg);
 	chanmask = 0;
 	if (reg & CBE_MIC_MNT_CFG_CHAN_0_POP)
 		chanmask |= 0x1;
@@ -180,7 +180,7 @@ static int __devinit cell_edac_probe(struct platform_device *pdev)
 			 "Yuck ! No channel populated ? Aborting !\n");
 		return -ENODEV;
 	}
-	dev_dbg(&pdev->dev, "Initial FIR = 0x%016lx\n",
+	dev_dbg(&pdev->dev, "Initial FIR = 0x%016llx\n",
 		in_be64(&regs->mic_fir));
 
 	/* Allocate & init EDAC MC data structure */
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 65929db..0f22e1a 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -676,7 +676,7 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
 
 	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->numchips = %d\n",
 	        chip->numchips);
-	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->chipsize = %ld\n",
+	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->chipsize = %lld\n",
 	        chip->chipsize);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->pagemask = %8x\n",
 	        chip->pagemask);
@@ -703,7 +703,7 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
 	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->ecc.layout = %p\n",
 	        chip->ecc.layout);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->flags = %08x\n", mtd->flags);
-	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->size = %d\n", mtd->size);
+	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->size = %lld\n", mtd->size);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->erasesize = %d\n",
 	        mtd->erasesize);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->writesize = %d\n",
@@ -932,7 +932,7 @@ static int __devinit fsl_elbc_chip_probe(struct fsl_elbc_ctrl *ctrl,
 #endif
 		add_mtd_device(&priv->mtd);
 
-	printk(KERN_INFO "eLBC NAND device at 0x%zx, bank %d\n",
+	printk(KERN_INFO "eLBC NAND device at 0x%llx, bank %d\n",
 	       res.start, priv->bank);
 	return 0;
 
diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
index 9bd6c9a..a8b9376 100644
--- a/drivers/mtd/nand/pasemi_nand.c
+++ b/drivers/mtd/nand/pasemi_nand.c
@@ -107,7 +107,7 @@ static int __devinit pasemi_nand_probe(struct of_device *ofdev,
 	if (pasemi_nand_mtd)
 		return -ENODEV;
 
-	pr_debug("pasemi_nand at %lx-%lx\n", res.start, res.end);
+	pr_debug("pasemi_nand at %llx-%llx\n", res.start, res.end);
 
 	/* Allocate memory for MTD device structure and private data */
 	pasemi_nand_mtd = kzalloc(sizeof(struct mtd_info) +
@@ -170,7 +170,7 @@ static int __devinit pasemi_nand_probe(struct of_device *ofdev,
 		goto out_lpc;
 	}
 
-	printk(KERN_INFO "PA Semi NAND flash at %08lx, control at I/O %x\n",
+	printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
 	       res.start, lpcctl);
 
 	return 0;
-- 
1.6.0.5

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion
  2009-01-21  0:16 [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion Stephen Rothwell
@ 2009-01-21  0:46 ` Arnd Bergmann
  2009-01-21  1:46 ` Olof Johansson
  2009-01-21 18:13 ` Scott Wood
  2 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2009-01-21  0:46 UTC (permalink / raw)
  To: linuxppc-dev
  Cc: Stephen Rothwell, Nick Spence, Scott Wood, Egor Martovetsky, Doug,
	linux-mtd, Thompson, Johansson, Paul Mackerras, Olof,
	David Woodhouse, bluesmoke-devel

On Wednesday 21 January 2009, Stephen Rothwell wrote:
> =A0drivers/edac/cell_edac.c =A0 =A0 =A0 =A0 | =A0 =A08 ++++----
> =A0drivers/mtd/nand/fsl_elbc_nand.c | =A0 =A06 +++---
> =A0drivers/mtd/nand/pasemi_nand.c =A0 | =A0 =A04 ++--
> =A03 files changed, 9 insertions(+), 9 deletions(-)
>=20
> If noone minds (seeing as how simple this patch is) we could just merge
> it via the powerpc tree.

=46ine with me (cell_edac bits in particular).

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion
  2009-01-21  0:16 [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion Stephen Rothwell
  2009-01-21  0:46 ` Arnd Bergmann
@ 2009-01-21  1:46 ` Olof Johansson
  2009-01-21 18:13 ` Scott Wood
  2 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2009-01-21  1:46 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Nick Spence, linuxppc-dev, Egor Martovetsky, Paul Mackerras,
	Doug Thompson, Scott Wood, linux-mtd, David Woodhouse,
	bluesmoke-devel

On Wed, Jan 21, 2009 at 11:16:51AM +1100, Stephen Rothwell wrote:
> These are all powerpc specific drivers.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

pasemi_nand.c pieces:

Acked-by: Olof Johansson <olof@lixom.net>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion
  2009-01-21  0:16 [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion Stephen Rothwell
  2009-01-21  0:46 ` Arnd Bergmann
  2009-01-21  1:46 ` Olof Johansson
@ 2009-01-21 18:13 ` Scott Wood
  2009-01-21 22:17   ` Stephen Rothwell
  2 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2009-01-21 18:13 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Nick Spence, linuxppc-dev, Egor Martovetsky, Paul Mackerras,
	Doug Thompson, Olof Johansson, linux-mtd, David Woodhouse,
	bluesmoke-devel

On Wed, Jan 21, 2009 at 11:16:51AM +1100, Stephen Rothwell wrote:
> -	printk(KERN_INFO "eLBC NAND device at 0x%zx, bank %d\n",
> +	printk(KERN_INFO "eLBC NAND device at 0x%llx, bank %d\n",
>  	       res.start, priv->bank);

This won't work if resource_size_t is 32-bit; it needs a cast.

ACK the other two fsl_elbc fixes.

-Scott

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion
  2009-01-21 18:13 ` Scott Wood
@ 2009-01-21 22:17   ` Stephen Rothwell
  2009-01-21 23:16     ` [PATCH v2] " Stephen Rothwell
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2009-01-21 22:17 UTC (permalink / raw)
  To: Scott Wood
  Cc: Nick Spence, David, linuxppc-dev, Egor, Paul Mackerras,
	Doug Thompson, Olof Johansson, linux-mtd, Woodhouse,
	bluesmoke-devel, Martovetsky

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Wed, 21 Jan 2009 12:13:24 -0600 Scott Wood <scottwood@freescale.com> wrote:
>
> On Wed, Jan 21, 2009 at 11:16:51AM +1100, Stephen Rothwell wrote:
> > -	printk(KERN_INFO "eLBC NAND device at 0x%zx, bank %d\n",
> > +	printk(KERN_INFO "eLBC NAND device at 0x%llx, bank %d\n",
> >  	       res.start, priv->bank);
> 
> This won't work if resource_size_t is 32-bit; it needs a cast.

Right.  Rats!  I'll fix and repost.

> ACK the other two fsl_elbc fixes.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] powerpc: more printing warning fixes for the l64 to ll64 conversion
  2009-01-21 22:17   ` Stephen Rothwell
@ 2009-01-21 23:16     ` Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2009-01-21 23:16 UTC (permalink / raw)
  To: Scott Wood
  Cc: Nick Spence, linuxppc-dev, Egor Martovetsky, Paul Mackerras,
	Doug Thompson, Olof Johansson, linux-mtd, David Woodhouse

These are all powerpc specific drivers.

res.start in fsl_elbc_nand.c needs to be cast since it may be either 32
or 64 bit.  Thanks to Scott Wood for noticing.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Arnd Bergmann <arnd@arndb.de> call_edac bits in particular
Acked-by: Olof Johansson <olof@lixom.net> pasemi_nand peices
Acked-by: Scott Wood <scottwood@freescale.com> fsl_elbc fixes
---
 drivers/edac/cell_edac.c         |    8 ++++----
 drivers/mtd/nand/fsl_elbc_nand.c |    8 ++++----
 drivers/mtd/nand/pasemi_nand.c   |    4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

The only change here is the cast noted above.  I removed bluesmoke-devel
because they reject my postings.

diff --git a/drivers/edac/cell_edac.c b/drivers/edac/cell_edac.c
index cd2e3b8..24f3ca8 100644
--- a/drivers/edac/cell_edac.c
+++ b/drivers/edac/cell_edac.c
@@ -36,7 +36,7 @@ static void cell_edac_count_ce(struct mem_ctl_info *mci, int chan, u64 ar)
 	struct csrow_info		*csrow = &mci->csrows[0];
 	unsigned long			address, pfn, offset, syndrome;
 
-	dev_dbg(mci->dev, "ECC CE err on node %d, channel %d, ar = 0x%016lx\n",
+	dev_dbg(mci->dev, "ECC CE err on node %d, channel %d, ar = 0x%016llx\n",
 		priv->node, chan, ar);
 
 	/* Address decoding is likely a bit bogus, to dbl check */
@@ -58,7 +58,7 @@ static void cell_edac_count_ue(struct mem_ctl_info *mci, int chan, u64 ar)
 	struct csrow_info		*csrow = &mci->csrows[0];
 	unsigned long			address, pfn, offset;
 
-	dev_dbg(mci->dev, "ECC UE err on node %d, channel %d, ar = 0x%016lx\n",
+	dev_dbg(mci->dev, "ECC UE err on node %d, channel %d, ar = 0x%016llx\n",
 		priv->node, chan, ar);
 
 	/* Address decoding is likely a bit bogus, to dbl check */
@@ -169,7 +169,7 @@ static int __devinit cell_edac_probe(struct platform_device *pdev)
 
 	/* Get channel population */
 	reg = in_be64(&regs->mic_mnt_cfg);
-	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
+	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016llx\n", reg);
 	chanmask = 0;
 	if (reg & CBE_MIC_MNT_CFG_CHAN_0_POP)
 		chanmask |= 0x1;
@@ -180,7 +180,7 @@ static int __devinit cell_edac_probe(struct platform_device *pdev)
 			 "Yuck ! No channel populated ? Aborting !\n");
 		return -ENODEV;
 	}
-	dev_dbg(&pdev->dev, "Initial FIR = 0x%016lx\n",
+	dev_dbg(&pdev->dev, "Initial FIR = 0x%016llx\n",
 		in_be64(&regs->mic_fir));
 
 	/* Allocate & init EDAC MC data structure */
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 65929db..1f6eb25 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -676,7 +676,7 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
 
 	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->numchips = %d\n",
 	        chip->numchips);
-	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->chipsize = %ld\n",
+	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->chipsize = %lld\n",
 	        chip->chipsize);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->pagemask = %8x\n",
 	        chip->pagemask);
@@ -703,7 +703,7 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
 	dev_dbg(ctrl->dev, "fsl_elbc_init: nand->ecc.layout = %p\n",
 	        chip->ecc.layout);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->flags = %08x\n", mtd->flags);
-	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->size = %d\n", mtd->size);
+	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->size = %lld\n", mtd->size);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->erasesize = %d\n",
 	        mtd->erasesize);
 	dev_dbg(ctrl->dev, "fsl_elbc_init: mtd->writesize = %d\n",
@@ -932,8 +932,8 @@ static int __devinit fsl_elbc_chip_probe(struct fsl_elbc_ctrl *ctrl,
 #endif
 		add_mtd_device(&priv->mtd);
 
-	printk(KERN_INFO "eLBC NAND device at 0x%zx, bank %d\n",
-	       res.start, priv->bank);
+	printk(KERN_INFO "eLBC NAND device at 0x%llx, bank %d\n",
+	       (unsigned long long)res.start, priv->bank);
 	return 0;
 
 err:
diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
index 9bd6c9a..a8b9376 100644
--- a/drivers/mtd/nand/pasemi_nand.c
+++ b/drivers/mtd/nand/pasemi_nand.c
@@ -107,7 +107,7 @@ static int __devinit pasemi_nand_probe(struct of_device *ofdev,
 	if (pasemi_nand_mtd)
 		return -ENODEV;
 
-	pr_debug("pasemi_nand at %lx-%lx\n", res.start, res.end);
+	pr_debug("pasemi_nand at %llx-%llx\n", res.start, res.end);
 
 	/* Allocate memory for MTD device structure and private data */
 	pasemi_nand_mtd = kzalloc(sizeof(struct mtd_info) +
@@ -170,7 +170,7 @@ static int __devinit pasemi_nand_probe(struct of_device *ofdev,
 		goto out_lpc;
 	}
 
-	printk(KERN_INFO "PA Semi NAND flash at %08lx, control at I/O %x\n",
+	printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
 	       res.start, lpcctl);
 
 	return 0;
-- 
1.6.0.5

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-21 23:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21  0:16 [PATCH] powerpc: more printing warning fixes for the l64 to ll64 conversion Stephen Rothwell
2009-01-21  0:46 ` Arnd Bergmann
2009-01-21  1:46 ` Olof Johansson
2009-01-21 18:13 ` Scott Wood
2009-01-21 22:17   ` Stephen Rothwell
2009-01-21 23:16     ` [PATCH v2] " Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).