linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Krill <ben@codiert.org>
To: linux-mtd@lists.infradead.org, dwg@au1.ibm.com,
	linuxppc-dev@ozlabs.org, vwool@ru.mvista.com
Subject: Re: [PATCH] Check name property to determine partition nodes.
Date: Fri, 23 Jan 2009 17:13:54 +0100	[thread overview]
Message-ID: <20090123161353.GG3306@codiert.org> (raw)
In-Reply-To: <20090123155142.GA481@codiert.org>

I missed a fix in this patch. I will resend it as v2.

cheers
 ben


* Benjamin Krill | 2009-01-23 16:51:42 [+0100]:

>SLOF has a further node which could not be evaluate
>by the current routine. The current routine returns
>because the node hasn't the required reg property. As
>fix this patch adds a check to determine the partition
>child nodes.
>
>Signed-off-by: Benjamin Krill <ben@codiert.org>
>---
> drivers/mtd/ofpart.c |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
>index 9e45b3f..c852cc2 100644
>--- a/drivers/mtd/ofpart.c
>+++ b/drivers/mtd/ofpart.c
>@@ -46,6 +46,11 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
> 		const u32 *reg;
> 		int len;
> 
>+		/* check if this is a partition node */
>+		partname = of_get_property(pp, "name", &len);
>+		if (strcmp(partname, "partition") != 0)
>+			continue;
>+
> 		reg = of_get_property(pp, "reg", &len);
> 		if (!reg || (len != 2 * sizeof(u32))) {
> 			of_node_put(pp);
>-- 
>1.6.0.6
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@ozlabs.org
>https://ozlabs.org/mailman/listinfo/linuxppc-dev

      reply	other threads:[~2009-01-23 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-23 15:51 [PATCH] Check name property to determine partition nodes Benjamin Krill
2009-01-23 16:13 ` Benjamin Krill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090123161353.GG3306@codiert.org \
    --to=ben@codiert.org \
    --cc=dwg@au1.ibm.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=vwool@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).