From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cursor.subgra.de (cursor.subgra.de [78.46.252.50]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "cursor.subgra.de", Issuer "cursor.subgra.de" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 50FF0DDF10 for ; Sat, 24 Jan 2009 03:14:24 +1100 (EST) Date: Fri, 23 Jan 2009 17:13:54 +0100 From: Benjamin Krill To: linux-mtd@lists.infradead.org, dwg@au1.ibm.com, linuxppc-dev@ozlabs.org, vwool@ru.mvista.com Subject: Re: [PATCH] Check name property to determine partition nodes. Message-ID: <20090123161353.GG3306@codiert.org> References: <20090123155142.GA481@codiert.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20090123155142.GA481@codiert.org> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , I missed a fix in this patch. I will resend it as v2. cheers ben * Benjamin Krill | 2009-01-23 16:51:42 [+0100]: >SLOF has a further node which could not be evaluate >by the current routine. The current routine returns >because the node hasn't the required reg property. As >fix this patch adds a check to determine the partition >child nodes. > >Signed-off-by: Benjamin Krill >--- > drivers/mtd/ofpart.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > >diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c >index 9e45b3f..c852cc2 100644 >--- a/drivers/mtd/ofpart.c >+++ b/drivers/mtd/ofpart.c >@@ -46,6 +46,11 @@ int __devinit of_mtd_parse_partitions(struct device *dev, > const u32 *reg; > int len; > >+ /* check if this is a partition node */ >+ partname = of_get_property(pp, "name", &len); >+ if (strcmp(partname, "partition") != 0) >+ continue; >+ > reg = of_get_property(pp, "reg", &len); > if (!reg || (len != 2 * sizeof(u32))) { > of_node_put(pp); >-- >1.6.0.6 > >_______________________________________________ >Linuxppc-dev mailing list >Linuxppc-dev@ozlabs.org >https://ozlabs.org/mailman/listinfo/linuxppc-dev