From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>
Cc: linux-rt-users@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER
Date: Wed, 4 Feb 2009 18:08:40 +0300 [thread overview]
Message-ID: <20090204150840.GC30027@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090204150755.GA24163@oksana.dev.rtsoft.ru>
Irqsoff, switch and preempt tracers use CALLER_ADDR macros, so they
should select FRAME_POINTER. Otherwise traces are meaningless.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
kernel/trace/Kconfig | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index e2a4ff6..48f7a37 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -86,6 +86,7 @@ config IRQSOFF_TRACER
select TRACE_IRQFLAGS
select TRACING
select TRACER_MAX_TRACE
+ select FRAME_POINTER
help
This option measures the time spent in irqs-off critical
sections, with microsecond accuracy.
@@ -108,6 +109,7 @@ config PREEMPT_TRACER
depends on DEBUG_KERNEL
select TRACING
select TRACER_MAX_TRACE
+ select FRAME_POINTER
help
This option measures the time spent in preemption off critical
sections, with microsecond accuracy.
@@ -136,6 +138,7 @@ config SCHED_TRACER
select TRACING
select CONTEXT_SWITCH_TRACER
select TRACER_MAX_TRACE
+ select FRAME_POINTER
help
This tracer tracks the latency of the highest priority task
to be scheduled in, starting from the point it has woken up.
--
1.5.6.5
next prev parent reply other threads:[~2009-02-04 15:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 19:06 [PATCH] ftrace: On PowerPC we don't need frame pointers for CALLER_ADDRs Anton Vorontsov
2009-02-02 0:35 ` Benjamin Herrenschmidt
2009-02-02 14:04 ` Steven Rostedt
2009-02-03 14:56 ` [PATCH v2] " Anton Vorontsov
2009-02-03 16:06 ` Ingo Molnar
2009-02-03 16:19 ` Anton Vorontsov
2009-02-03 16:32 ` Steven Rostedt
2009-02-03 18:59 ` Anton Vorontsov
2009-02-04 0:34 ` Benjamin Herrenschmidt
2009-02-04 15:07 ` Anton Vorontsov
2009-02-04 15:08 ` [PATCH 1/3] Makefile: Include arch Makefiles as late as possible Anton Vorontsov
2009-02-04 21:26 ` Ingo Molnar
2009-02-11 3:51 ` Benjamin Herrenschmidt
2009-02-11 13:23 ` Ingo Molnar
2009-02-11 14:11 ` Steven Rostedt
2009-02-14 19:58 ` Sam Ravnborg
2009-02-14 19:57 ` Sam Ravnborg
2009-02-14 22:03 ` Ingo Molnar
2009-02-15 0:19 ` Benjamin Herrenschmidt
2009-02-15 8:09 ` Ingo Molnar
2009-02-16 14:20 ` Anton Vorontsov
2009-02-16 14:53 ` Anton Vorontsov
2009-02-16 20:04 ` Sam Ravnborg
2009-02-16 16:08 ` Anton Vorontsov
2009-02-16 17:22 ` Ingo Molnar
2009-02-04 15:08 ` [PATCH 2/3] powerpc: Make it possible to safely select CONFIG_FRAME_POINTER Anton Vorontsov
2009-02-05 0:31 ` Benjamin Herrenschmidt
2009-02-05 0:35 ` Steven Rostedt
2009-02-05 1:12 ` Anton Vorontsov
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:30 ` Anton Vorontsov
2009-02-05 15:45 ` Anton Vorontsov
2009-02-04 15:08 ` Anton Vorontsov [this message]
2009-02-04 15:26 ` [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER Frédéric Weisbecker
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:36 ` Anton Vorontsov
2009-02-04 16:50 ` Frédéric Weisbecker
2009-02-04 8:17 ` [PATCH v2] ftrace: On PowerPC we don't need frame pointers forCALLER_ADDRs Usha Rani Konudula
2009-02-04 8:37 ` Usha Rani Konudula
-- strict thread matches above, loose matches on Subject: below --
2009-03-20 16:44 [PATCH v4 0/3] Tracers vs. CALLER_ADDR on PowerPC Anton Vorontsov
2009-03-20 16:44 ` [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER Anton Vorontsov
2009-05-02 0:13 [PATCH v5 0/3] Tracers vs. CALLER_ADDR on PowerPC Anton Vorontsov
2009-05-02 0:14 ` [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204150840.GC30027@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).