From: wli@movementarian.org
To: Roland Dreier <rdreier@cisco.com>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Eli Cohen <eli@mellanox.co.il>
Subject: Re: FW: [PATCH] powerpc/mm: Export HPAGE_SHIFT
Date: Wed, 4 Feb 2009 16:00:37 -0500 [thread overview]
Message-ID: <20090204210037.GC10229@movementarian.org> (raw)
In-Reply-To: <adad4dym2zp.fsf@cisco.com>
On Wed, Feb 04, 2009 at 11:11:22AM -0800, Roland Dreier wrote:
> Heh. Looking into the implementation, it seems that I could actually do
> PAGE_SIZE << compound_order(page)
> directly (since there's no reason to go from size to hstate and back to
> size. I don't know all the details of these VM internals, but that
> seems to only work on the first (small) page of a giant page? Which
> causes problems for what we're trying to do here...
You should be able to find the head of a compound page using the
compound_head() inline, so try
PAGE_SIZE << compound_order(compound_head(page))
-- wli
next prev parent reply other threads:[~2009-02-04 21:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090203164930.GA10101@mtls03>
2009-02-04 1:08 ` FW: [PATCH] powerpc/mm: Export HPAGE_SHIFT Roland Dreier
2009-02-04 1:50 ` Benjamin Herrenschmidt
2009-02-04 5:13 ` Andrew Morton
2009-02-04 5:31 ` Nick Piggin
2009-02-04 6:17 ` wli
2009-02-04 6:16 ` Roland Dreier
2009-02-04 6:26 ` Andrew Morton
2009-02-04 19:11 ` Roland Dreier
2009-02-04 21:00 ` wli [this message]
2009-02-04 21:31 ` Roland Dreier
2009-02-04 21:23 ` Andrew Morton
2009-02-04 23:55 ` Benjamin Herrenschmidt
2009-02-05 5:10 ` Roland Dreier
2009-02-05 5:24 ` Benjamin Herrenschmidt
2009-02-05 5:33 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204210037.GC10229@movementarian.org \
--to=wli@movementarian.org \
--cc=akpm@linux-foundation.org \
--cc=eli@mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).