* [PATCH] Don't emulate mr. instructions
@ 2009-02-06 12:02 Ananth N Mavinakayanahalli
0 siblings, 0 replies; only message in thread
From: Ananth N Mavinakayanahalli @ 2009-02-06 12:02 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Paul Mackerras
Currently emulate_step() emulates mr. instructions without updating cr0
and this can be disastrous. Don't emulate mr.
This bug has been around for a while, but I am not sure if its a worthy
-stable candidate. I'll leave it to Ben do decide.
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
---
arch/powerpc/lib/sstep.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.29-rc3/arch/powerpc/lib/sstep.c
===================================================================
--- linux-2.6.29-rc3.orig/arch/powerpc/lib/sstep.c
+++ linux-2.6.29-rc3/arch/powerpc/lib/sstep.c
@@ -172,6 +172,8 @@ int __kprobes emulate_step(struct pt_reg
}
break;
case 0x378: /* orx */
+ if (instr & 1)
+ break;
rs = (instr >> 21) & 0x1f;
rb = (instr >> 11) & 0x1f;
if (rs == rb) { /* mr */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-02-06 12:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-06 12:02 [PATCH] Don't emulate mr. instructions Ananth N Mavinakayanahalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).